Mention style highlighting in the query bar doesn't have rounded borders

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.95-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): Expense

Action Performed:

1. Navigate to report search > Expenses
2. Click Search and enter anything to search
3. Observe the mention style highlighting in the query bar

Expected Result:

Mention style highlighting in the query bar should have rounded borders

Actual Result:

Mention style highlighting in the query bar doesn't have rounded borders

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention style highlighting in the query bar doesn't have rounded borders

What is the root cause of that problem?

When users search type: expense, we're consider the expense as the mention-user, and we define the style for mention-user in

App/src/hooks/useMarkdownStyle.ts

Lines 71 to 73 in b0b7709

	mentionUser: {
	color: theme.mentionText,
	backgroundColor: theme.mentionBG,

so there's no borderRadius here.

What changes do you think we should make in order to solve the problem?

1. Add borderRadius: 4 to mentionUser. We can adjust this value

2. Add borderRadius in here, so the borderRadius attribute is applied for the nested span

3. Apply the borderRadius in styleUtil

Note: This way will change the mention-user in chat as well, so I think it's fine for consistency. If we want to applied for search only, we can add the flag to disable it in chat.

We also can consider to add rounded border for mention-report, mention-here, ...

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

No need for unit test, since it's UI issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

POC