Import both PDF.js workers and apply legacy for prev. IOS #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…remove debug logs
rezkiy37
changed the title
|
LGTM, but just to clarify there should be the |
|
@jjcoffee, yes. It is expected behavior. We had it before as well 🙂 |
|
@mountiny, can you please merge the PR? It has been approved 🙂 |
8 tasks
mountiny
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Import both PDF.js workers and apply the legacy version for previous iOS versions by obtaining the iOS version. If the user’s age is less than 18, use legacy code; otherwise, use modern code.
Screenshots
Related Issues
Expensify/App#55176
Manual Tests
Linked PRs