-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FrelonSegmenterGui
: Extract choose_frame
and segment_frame
as functions
#368
Comments
choose_frame
and segment_frame
as functionsFrelonSegmenterGui
: Extract choose_frame
and segment_frame
as functions
Extracting For If you can send a pull request then I don't see any reason not to merge it? Thanks! |
Thanks for the encouraging words @jonwright ! @abmajith did a MR (#374) for the |
Solved by #374 and #376, thanks @abmajith and @loichuder ! |
For #358
@abmajith did some progress on #358 and would need to reuse some part of the
FrelonSegmeterGui
but without theGui
.The two methods we are interested in are the
choose_frame
method and thesegment_frame
method. These are not tied to the ipywidgets so we could extract them to reuse them outside of theFrelonSegmeterGui
which is tied to Jupyter.Would that be ok if we extract the relevant code in functions ? We could them call them outside of
FrelonSegmeterGui
without any functional change to this class ?Of course, we are happy to discuss this further if you think of another strategy 👍
The text was updated successfully, but these errors were encountered: