Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 16 support #300

Closed
rr-hornback opened this issue May 25, 2023 · 9 comments
Closed

Angular 16 support #300

rr-hornback opened this issue May 25, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@rr-hornback
Copy link

Bug Report

Please answer the following questions for yourself before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

  • [ x] I am running the latest version
  • [ x] I checked the Readme and found no answer
  • [ x] I checked to make sure that this issue has not already been filed
  • [ x] This is related to angular-google-charts and not to Google Charts directly (if it's a Google Charts issue, their forum may help)
@rr-hornback rr-hornback added the bug Something isn't working label May 25, 2023
@faraz-ahmad-uft
Copy link

@rr-hornback - I am also facing the same issue.
I am trying to upgrade my project to Angular v16 but due to incompatible version issues of this package, I am not able to do this.

@kussmaul
Copy link
Contributor

Have you tried adapting the workaround described for Angular 15?
#292 (comment)

@faraz-ahmad-uft
Copy link

@kussmaul - Yes I tried that as well but unfortunately did not work for me.

@rr-hornback
Copy link
Author

We are currently using the overrides in our package.json file as a temporary workaround. Would be nice to have an officially supported version.

"overrides": { "angular-google-charts": { "@angular/common": "^16.0.3", "@angular/core": "^16.0.3" } }

@faraz-ahmad-uft
Copy link

@rr-hornback - I added overrides in my package.json file but I am still getting the same error.

@kussmaul
Copy link
Contributor

You might get more specific suggestions if you provide more detail than "the same error" - exactly what error do you get? What is your package.json? What else have you tried? (see the bug report template for more)

@mohamed-badaoui
Copy link

mohamed-badaoui commented Jun 5, 2023

@rr-hornback - I added overrides in my package.json file but I am still getting the same error.

Same error even with the override in package.json

Package "angular-google-charts" has an incompatible peer dependency to "@angular/common" (requires ">=6.0.0 <=14.x.x" (extended), would install "16.0.4").
                  Package "angular-google-charts" has an incompatible peer dependency to "@angular/core" (requires ">=6.0.0 <=14.x.x" (extended), would install "16.0.4").
✖ Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.
  See "/tmp/ng-JYz5dg/angular-errors.log" for further details.

The only way to make it work is to use the --force option in the ng update command.

@TamerHussien
Copy link

We are currently using the overrides in our package.json file as a temporary workaround. Would be nice to have an officially supported version.

"overrides": { "angular-google-charts": { "@angular/common": "^16.0.3", "@angular/core": "^16.0.3" } }

That works for me, just add @angular/common and @angular/core versions as same as in your package.json.

@FERNman
Copy link
Owner

FERNman commented Sep 2, 2024

Closing in favor of #312

@FERNman FERNman closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants