From 81f0e2584b794569d81cd5c96b796acc21cae917 Mon Sep 17 00:00:00 2001 From: FantasticFiasco Date: Tue, 15 Dec 2015 20:48:42 +0100 Subject: [PATCH 1/3] Attempted to fix issue 2 by pruning the views before unregistering specified view. --- src/MvvmDialogs/DialogServiceViews.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/MvvmDialogs/DialogServiceViews.cs b/src/MvvmDialogs/DialogServiceViews.cs index 26aeaa17..4e60885d 100644 --- a/src/MvvmDialogs/DialogServiceViews.cs +++ b/src/MvvmDialogs/DialogServiceViews.cs @@ -4,7 +4,6 @@ using System.Linq; using System.Windows; using MvvmDialogs.Logging; -using MvvmDialogs.Properties; using MvvmDialogs.Views; namespace MvvmDialogs @@ -143,8 +142,8 @@ private static void Unregister(IView view) { if (view == null) throw new ArgumentNullException("view"); - if (!InternalViews.Any(registeredView => ReferenceEquals(registeredView.Source, view.Source))) - throw new ArgumentException(Resources.ViewNotRegistered.CurrentFormat(view.GetType()), "view"); + + PruneInternalViews(); Logger.Write("Unregister view {0}".InvariantFormat(view.Id)); InternalViews.RemoveAll(registeredView => ReferenceEquals(registeredView.Source, view.Source)); From e16e5c7405b39a43747b3bb27666b9430d84200f Mon Sep 17 00:00:00 2001 From: FantasticFiasco Date: Tue, 15 Dec 2015 20:52:56 +0100 Subject: [PATCH 2/3] Configured NuGet package to be a pre-release. --- appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 0d66ebbb..2289af61 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -18,7 +18,7 @@ assembly_info: file: src\SolutionInfo.cs assembly_version: '{version}.0' assembly_file_version: '{version}.0' - assembly_informational_version: '{version}' + assembly_informational_version: '{version}-issue2' #---------------------------------# From ab6d13b5e1f29c7e7d33b42c71d46937f43c9762 Mon Sep 17 00:00:00 2001 From: Mattias Kindborg Date: Wed, 13 Jan 2016 06:35:19 +0100 Subject: [PATCH 3/3] Removed beta version from NuGet package. --- appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 2289af61..0d66ebbb 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -18,7 +18,7 @@ assembly_info: file: src\SolutionInfo.cs assembly_version: '{version}.0' assembly_file_version: '{version}.0' - assembly_informational_version: '{version}-issue2' + assembly_informational_version: '{version}' #---------------------------------#