Jackson reports wrong locations for JsonEOFException

[wastevenson]

I noticed the the locations reported for JsonEOFException are wrong for both InputStream and Reader based parsers. The values are about 2x higher than they should be. It looks like the problem is that in _loadMore for UTF8StreamJsonParser and in ReaderBasedJsonParser the value for _currInputRowStart is adjusted even if the read fails but _inputPtr is set to 0 only if the read succeeds. When the location is calculated for the exception the count from the last buffer is included in both from _inputPtr and in _currInputRowStart doubling the value.

[cowtowncoder]

Sounds plausible. Would it be possible to get a simple reproduction with test input stream and/or reader that would exhibit the problem?

[DiggidyDale]

Is there any update on this, as I am currently having an issue and I can't pinpoint the issue as my JSON string of 173 characters is reporting an EOF issue at column 345

[cowtowncoder]

At this pointI will not have time to work on this any time soon. So any progress would likely be from contributions.

But as importantly, please note need-test-case tag: for anyone to work on this, reproduction is needed.

[toddobryan]

With current master, here's a test case that's probably related to this:

    public void testLocation() throws Exception
    {
        JsonParser p = createParserUsingReader("42");
        while (p.nextToken() != null) {
            p.nextToken();
        }
        System.out.println(p.getCurrentLocation());
    }

The results are: [Source: (StringReader); line: 1, column: 9]

Note that that's for a StringReader with 2 characters.

[cowtowncoder]

Thank you @toddobryan!

[cowtowncoder]

Added a failing unit test -- definitely seems to double up counts; I wonder if that is due to special handling of root-level values. Hope to look into this again soon; problem affects both Reader (char-based) and InputStream (byte-based) parsers, via this trivial test.

[toddobryan]

Sending a pull request that includes tests for getTokenLocation() and getCurrentLocation() at the end of the stream.

[cowtowncoder]

Thanks, but I already added tests (based on snippet above) -- but perhaps you could modify what I added, as I only tested getCurrentLocation().

[toddobryan]

Oh, my PR includes a fix.

[cowtowncoder]

ahhh! Excellent.

So, just one process thing in that case: unless I have asked for and received CLA, that would be needed before the first contribution. It can be found here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual mechanism is to print it, fill, sign & scan, email to info at fasterxml dot com.
Only needs to be done once and good from that point on for all Jackson projects.

[toddobryan]

#557

I'll deal with the CLA later today.

[cowtowncoder]

Thank you!

[cowtowncoder]

@toddobryan Hi there! Sorry to bother you but I was wondering if you might be able to do this next week? Was hoping to get this in 2.10.0.
Not a big deal if not, will then go in 2.10.1, but it's a good improvement.