Fix NPE in writeNumber(String)
method of UTF8JsonGenerator
, WriterBasedJsonGenerator
#647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced NPE in writeNumber(String) of UTF8JsonGenerator when trying to pass null into this method.
gen.writeNumber(getStringValue());
where
getStringValue()
method can return null, and this causes NPE in writeRaw(String text) method of generator.But it works fine for writeNumber(BigDecimal) and writeNumber(BigInteger) methods if I pass null into those methods.
Thus, I added null check for
writeNumber(String encodedValue)
the same as it made for BigDecimal and BigInteger types. Furthermore modified some tests for this nullability check.