-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce O(n^1.5) BigDecimal parser implementation #677
Introduce O(n^1.5) BigDecimal parser implementation #677
Conversation
@ferenc-csaky Sounds good -- thank you very much for the contribution! -- and it looks like I have CLA from you already. Just one request: could this be rebased against 2.13? |
Changed the base branch to |
Just realized that none of the tests verifies new code path(s), I think. Will repurpose some from original... should have caught this earlier,. |
@ferenc-csaky Hmmh. I think there may be a bug somewhere, some offset not being carried or used for calculations? One thing that is tricky, too, is how to propagate underlying secondary fails, if those are possible (not sure if they are after fixing this). |
Looks like |
Oh yes, you are totally right, I didn't follow the source impl. exactly and I messed it up. Sorry about it. I just created a PR with the fix. Now the test you added runs correctly. |
@ferenc-csaky np. Just glad this was caught :) |
Covers the
BigDecimal
part of #577. Thedouble
/float
implementations would require a much bigger refactor, since the example implementation follows a very different approach, but IMO it's worth to update only theBigDecimal
without the others as well.