When applying type modifiers, don't ignore container types. #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
added a commit
that referenced
this pull request
Feb 21, 2016
When applying type modifiers, don't ignore container types.
|
Yes, as per Scala changes I assume this is absolutely necessary. Will add some commentary; this is slightly risky change (i.e. ideally would have went in 2.7.0), but without it Scala module 2.7 probably won't work very well, so I am ok with it. Assumption also being that type modifications are not commonly used by things other than Jackson core modules AND that they are properly guarded already (meaning should not apply to types for which calls were not made formerly). |
cowtowncoder
added a commit
that referenced
this pull request
Feb 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jackson-module-scala relies on using type modifiers to find Maps/Seqs... etc. Maps are subtypes of Iterable[Tuple2[,]] which means that the CollectionLikeType is found before the MapLikeType and it is unable to be overwritten by a type modifier once the super types have been resolved.