Don't re-use dynamic serializers for property-updating copy constructors #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: dynamic serializers may hold property name and therefore must be re-created when the property changes (backport of 3b1cf09 from 3.0 branch)
|
Thank you for submitting this! I'll have to think this through once more but I think you are right. |
|
2.9.7+ will be great as well! Thank you! |
|
@cowtowncoder can you please give a status update on this? |
|
@morj sorry, I have not had much time for Jackson for past 2 weeks, but I am now merging this. Thank you again for help here! It will go in 2.9.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: dynamic serializers may hold property name and therefore must be re-created when the property changes.
(backport of 3b1cf096779bf3756794d2e325088b73b9e66e1b from 3.0 branch)
Feel free to re-create this change yourself it you accept it, but signing the CLA can take a while. Our prioirty is to have it in central with upcoming 2.10+ releases.