Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ObjectArrayDeserializer to use "generic" type parameter (java.lang.Object) to remove co-variant return type #4263

Closed
cowtowncoder opened this issue Dec 14, 2023 · 0 comments
Closed

Change ObjectArrayDeserializer to use "generic" type parameter (java.lang.Object) to remove co-variant return type #4263

cowtowncoder opened this issue Dec 14, 2023 · 0 comments
Labels
2.17 Issues planned at earliest for 2.17

Comments

@cowtowncoder
Copy link
Member

Describe your Issue

Looking at stack traces, it looks like co-variant method calls induced by generic typing for JsonDeserializer adds one stack frame per call. While not performance issue in general, this can be problematic for deep call stacks which are possible for this specific type; and in particular for Fuzzer-generated scenarios. To reduce call stack depth, let's change parameterization to be plain old java.lang.Object (instead of current Object[]).
@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.17 Issues planned at earliest for 2.17 and removed to-evaluate Issue that has been received but not yet evaluated labels Dec 14, 2023
cowtowncoder added a commit that referenced this issue Dec 14, 2023
@cowtowncoder
Fix #4263: remove generic type parameterization from `ObjectArrayDese…
302c5d9 
…rializer`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.17 Issues planned at earliest for 2.17
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder