Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jackson-jr-stree-2.11.1.jar is missing util package classes #74

Closed
totierne opened this issue Jul 20, 2020 · 5 comments
Closed

jackson-jr-stree-2.11.1.jar is missing util package classes #74

totierne opened this issue Jul 20, 2020 · 5 comments
Milestone

Comments

@totierne
Copy link

jackson-jr-stree-2.11.1.jar is missing util package classes

All classes in that jar are in package com/fasterxml/jackson/jr/stree

whereas sources contains: com/fasterxml/jackson/jr/stree/util/JrsTreeTraversingParser.java (for example) in util package

(I was alerted by a class not found exception).

Looking a little further back:
jackson-jr-stree-2.11.0.jar contains 95 files including com/fasterxml/jackson/jr/ob files (These could be generated files, I do not see them in jackson-jr-stree-2.11.0-sources.jar)
whereas:
jackson-jr-stree-2.11.1.jar has 27 files all from com/fasterxml/jackson/jr/stree

Thank you for your time,
Turloch O'Tierney
[email protected]
[email protected]

Additional notes:
diffing the poms gives some osgi change
2.11.1:


<osgi.export>${project.groupId}.stree;version=${project.version}</osgi.export>

<packageVersion.dir>com/fasterxml/jackson/jr/stree</packageVersion.dir>
<packageVersion.package>${project.groupId}.stree</packageVersion.package>

2.11.0

<packageVersion.dir>com/fasterxml/jackson/jr/stree</packageVersion.dir>
<packageVersion.package>${project.groupId}.stree</packageVersion.package>
<packageVersion.template.input>${basedir}/src/main/java/${packageVersion.dir}/PackageVersion.java.in</packageVersion.template.input>
<packageVersion.template.output>${generatedSourcesDir}/${packageVersion.dir}/PackageVersion.java</packageVersion.template.output>

@totierne
Copy link
Author

totierne commented Jul 20, 2020

Undoing that maven change resulted in 95 class files - including the util package in output jackson-jr-stree-2.11.1.jar.

@cowtowncoder
Copy link
Member

Ugh. Must be due to #72 that solved the opposite problem (and seems to have introduced a new one then?)

@cowtowncoder
Copy link
Member

Ah. Missing wild-card after value of osgi.export.

Thank you for reporting the issue.

@cowtowncoder
Copy link
Member

Fixed, now contains expected classes, without copying duplicate classes from dependencies.
Will be included in 2.11.2.

@totierne
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants