Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta does not have jakarta.validation as module-info dependency #161

Closed
oldmanpushcart opened this issue Dec 15, 2024 · 6 comments
Closed
Milestone

Comments

@oldmanpushcart
Copy link

oldmanpushcart commented Dec 15, 2024

I got an error!

java.lang.module.FindException: Module validation.api not found, required by com.fasterxml.jackson.module.jsonSchema.jakarta

when I found jackson-module-jsonSchema-jakarta's module-info.class, It used validation.api

module com.fasterxml.jackson.module.jsonSchema.jakarta {
    requires validation.api;
    requires com.fasterxml.jackson.annotation;
    requires com.fasterxml.jackson.core;
    requires com.fasterxml.jackson.databind;

    exports com.fasterxml.jackson.module.jsonSchema.jakarta;
    exports com.fasterxml.jackson.module.jsonSchema.jakarta.annotation;
    exports com.fasterxml.jackson.module.jsonSchema.jakarta.customProperties;
    exports com.fasterxml.jackson.module.jsonSchema.jakarta.factories;
    exports com.fasterxml.jackson.module.jsonSchema.jakarta.types;
    exports com.fasterxml.jackson.module.jsonSchema.jakarta.validation;
}

But I check your source code, used validation.api.

Now, I have 2 question

  1. why choice validation.api
  2. how can fix my probrom?

thank you very much

@oldmanpushcart
Copy link
Author

about question1, I found #150

@pjfanning
Copy link
Member

That module-info setting is probably an oversight. Based on https://github.com/jakartaee/validation/blob/main/src/main/java/module-info.java, it should probably be jakarta.validation.

Let me have a look.

@pjfanning
Copy link
Member

@oldmanpushcart I have added #162. Would you be able to make this change and build jackson-module-jsonSchema for yourself to try the jar with the change?

@cowtowncoder
Copy link
Member

Yes, I think this must have been copy-paste error by submitted of Jakarta version (and one code reviewer (me) did not catch).

#162 seems legit (and I will merge) but verification by @oldmanpushcart would be much appreciated.

@cowtowncoder cowtowncoder added this to the 2.18.3 milestone Dec 17, 2024
@cowtowncoder cowtowncoder changed the title why jakarta don't use jakarta.validation? Jakarta does not have jakarta.validation as module-info dependency Dec 17, 2024
cowtowncoder added a commit that referenced this issue Dec 17, 2024
@oldmanpushcart
Copy link
Author

@pjfanning I build master(2.19.0-SNAPSHOT) on my laptop, It's work's fine. Thank you very much~
@cowtowncoder verification pass. Hope we can see the feature in 2.18.3

@cowtowncoder
Copy link
Member

Thank you for verifying, @oldmanpushcart .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants