-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta does not have jakarta.validation
as module-info
dependency
#161
Comments
about question1, I found #150 |
That module-info setting is probably an oversight. Based on https://github.com/jakartaee/validation/blob/main/src/main/java/module-info.java, it should probably be jakarta.validation. Let me have a look. |
@oldmanpushcart I have added #162. Would you be able to make this change and build jackson-module-jsonSchema for yourself to try the jar with the change? |
Yes, I think this must have been copy-paste error by submitted of Jakarta version (and one code reviewer (me) did not catch). #162 seems legit (and I will merge) but verification by @oldmanpushcart would be much appreciated. |
jakarta.validation
as module-info
dependency
@pjfanning I build master(2.19.0-SNAPSHOT) on my laptop, It's work's fine. Thank you very much~ |
Thank you for verifying, @oldmanpushcart . |
I got an error!
when I found
jackson-module-jsonSchema-jakarta
's module-info.class, It usedvalidation.api
But I check your source code, used
validation.api
.Now, I have 2 question
validation.api
thank you very much
The text was updated successfully, but these errors were encountered: