Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name for JDK9 interoperability #77

Closed
forax opened this issue Jun 12, 2018 · 4 comments
Closed

Add Automatic-Module-Name for JDK9 interoperability #77

forax opened this issue Jun 12, 2018 · 4 comments

Comments

@forax
Copy link

forax commented Jun 12, 2018

Hi,
FasterXML/jackson-core#397 add Automatic-Module-Name to core and databind but other projects like jackson-annotations were not updated.

Stephen Colebourne has started to list all projects that have a list an Automatic-Module-Name, as you can see only core and databind have been updated
https://github.com/jodastephen/jpms-module-names/blob/master/generated/module-maven.properties#L1

I personally need jackson-annotations and jackson-module-java8 so i will log a bug for these two modules but all modules should be updated IMO.

@cowtowncoder
Copy link
Member

jackson-annotations actually got this for 2.9.1, I think; I need to think of what to do with jackson-bom since ideally I would drop patch revision, but in this one specific case there is a reason for dependency to later patch version..

As to other repos; you can add issues for repos that are missing this, but I thought that parent pom actually includes instructions to generate module name.
There definitely should be module names for other repose so I am not quite sure where discrepancy comes from: it is possible I guess that information is somehow incorrect. I think I did verify just that metadata entry is added in Manifest, but Oracle's tooling for pre-Java-9 hasn't allowed much other verification.

@cowtowncoder
Copy link
Member

Looking at jars build for 2.9.6 for, say, java8 datetime, does show:

Manifest-Version: 1.0
Automatic-Module-Name: com.fasterxml.jackson.datatype.jsr310
Bnd-LastModified: 1528839425523
Build-Jdk: 1.8.0_102

and similarly for base modules.

So to me it seems like automatic name is included.

Is Stephen's list generated from artifacts from Maven, or using some other means?

@forax
Copy link
Author

forax commented Jun 13, 2018

yes,
the generator used for creating Stephen's list was not scanning Central for jackson, i've sent a pull request for that (jodastephen/jpms-module-names#20).

@forax forax closed this as completed Jun 13, 2018
@cowtowncoder
Copy link
Member

@forax Ah. That would explain it. Thank you for the follow-up, to make sure Jackson components' information is up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants