Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criteria for oda damping value #142

Open
thudjx opened this issue May 4, 2024 · 1 comment
Open

criteria for oda damping value #142

thudjx opened this issue May 4, 2024 · 1 comment

Comments

@thudjx
Copy link

thudjx commented May 4, 2024

In the original paper of oda, the criteria for damping value is:
$$\lambda_m = \begin{cases} 1, & c\le-s/2 \ -s/2c, & \text{otherwise} \end{cases}$$.
However, the code seems discrepent with the formula.
Is this a mistake or am I missing something here?

@gustavojra
Copy link
Member

Hi @thudjx , thanks for pointing it out. It seems to me that there is indeed a small discrepancy. I will try checking with the folks who wrote that part of the code to make sure it's a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants