Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README and information #1

Open
mckaygerhard opened this issue Mar 14, 2022 · 3 comments
Open

README and information #1

mckaygerhard opened this issue Mar 14, 2022 · 3 comments

Comments

@mckaygerhard
Copy link

.. also i check your code for this mod and it seems try to detect max mem usage and "free" but using collect garbage.. is a hacked way to do so but not so smart.. the best way is to modifiy each mod to reduce usage.. and alter the way how the engine manage the entities

what is the purpose target?

also i am interested in improved the engine you forked but you should activate the issues..

@Festus1965
Copy link
Owner

Festus1965 commented Mar 14, 2022

that as the way I could solve the problem long time ago,
if there are new options in LuaJit so detect and clean up

max was used to detect and remember in log last working high memory usage BEFORE a crash
oom was used then to set a timeframe and this got maximum to regular clean up BEFORE it reach max and possible crash

write it new,
as of I haven't seen any memory problems anymore since 2+ years
code is obsolete if it doesn't work anymore OR/AND there are new options

at my server I reach 62888 KB after last mod is loaded, maybe gives you a hint.
about 298 MB are detected max with monitoring at my last test with monitoring,
see https://monitoring.minetest.land/d/YUpouLmWk/lua-server-monitoring-mod?tab=visualization&orgId=1&var-instance=AsiaThailand&from=1647016961278&to=1647215817679
Pandorabox is about next to 500 MB,
Prismo even over 700 MB

and my not changed minetest.conf still has inside this parameter:
# for [Mod] free_lj_mem 1.5 looptime = 86400 maxluamem = 350000

so you see proofed max about 700 MB now,
but my server still is under 300 MB and settings with clean up at 350 MB would still make sence here.

So if you don't have a problem with out of memory crash !!!
why touch it ?
IF you have, check out if it still works,
and if not make it new with SURE better new options there might be now.

@mckaygerhard
Copy link
Author

very informative.. why not put that in the README and then archive or staled the mod!

i will made those analysis for my one.. I haven't had memory problems since the authenticate method changed to sorceredkid's auth_rx, but I would be interested in knowing more about what I use so thanks for this plugin

and thanks for the response!

@mckaygerhard
Copy link
Author

ah, and why not put this infor more elaborate in README=?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants