Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a generic floating toolbar aligner #18

Open
matthew-carroll opened this issue Nov 18, 2023 · 0 comments
Open

Create a generic floating toolbar aligner #18

matthew-carroll opened this issue Nov 18, 2023 · 0 comments

Comments

@matthew-carroll
Copy link
Contributor

Currently we have a Cupertino toolbar aligner. This alignment strategy is reasonable for other toolbars, too, but it's confusing to use a Cupertino aligner in non-Cupertino use-cases. Create a generic floating toolbar aligner. If the generic aligner works the same way as Cupertino, consider making the Cupertino aligner a dumb delegate to the generic strategy. In theory we could remove the Cupertino aligner, if the generic aligner is the same, but we don't want to break all the uses of the Cupertino aligner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant