From 86adab44dbd3b1d2e330b020b3f3b479cfc789b5 Mon Sep 17 00:00:00 2001 From: Cornelius Ashley-Osuzoka <59456456+corneliusyaovi@users.noreply.github.com> Date: Sat, 8 Apr 2023 02:26:46 +0100 Subject: [PATCH 1/4] Add contributing guidelines --- CONTRIBUTING.md | 95 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..e0fe6a0 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,95 @@ +

+ +

+ +Thank you for taking the time to contribute to our library🙌🏾. + +In this section, we detail everything you need to know about contributing to this library. + + +**[Code of Conduct](https://github.com/probot/template/blob/master/CODE_OF_CONDUCT.md)** + +## **I don't want to contribute, I have a question** + +Please don't raise an issue to ask a question. You can ask questions on our [forum](http://forum.flutterwave.com) or developer [slack](https://bit.ly/34Vkzcg). We have an army of Engineers on hand to answer your questions there. + +## How can I contribute? + +### Reporting a bug + +Have you spotted a bug? Fantastic! Before raising an issue, here are some things to do: + +1. Search to see if another user has reported the bug. For existing issues that are still open, add a comment instead of creating a new one. +2. Check our forum and developer slack to confirm that we did not address it there. + +When you report an issue, it is important to: + +1. Explain the problem + - Use a clear and descriptive title to help us to identify the problem. + - Describe steps we can use to replicate the bug and be as precise as possible. + - Include screenshots of the error messages. +2. Include details about your configuration and setup + - What version of the library are you using? + - Did you experience the bug on test mode or live? + - Do you have the recommended versions of the library dependencies? + + + +### Requesting a feature + +If you need an additional feature added to the library, kindly send us an email at developers@flutterwavego.com. Be sure to include the following in your request: + +1. A clear title that helps us to identify the requested feature. +2. A brief description of the use case for that feature. +3. Explain how this feature would be helpful to your integration. +4. Library name and version. + +### Submitting changes (PR) + +Generally, you can make any of the following changes to the library: + +1. Bug fixes +2. Performance improvement +3. Documentation update +4. Functionality change (usually new features) + + + +Follow these steps when making a pull request to the library: + +1. Fork the repository and create your branch from master. +2. For all types of changes (excluding documentation updates), add tests for the changes. +3. If you are making a functionality change, update the docs to show how to use the new feature. +4. Ensure all your tests pass. +5. Make sure your code lints. +6. Write clear log messages for your commits. one-liners are fine for small changes, but bigger changes should have a more descriptive commit message (see sample below). +7. Use present tense for commit messages, "Add feature" not "Added feature”. +8. Ensure that you fill out all sections of the PR template. +9. Raise the PR against the `staging` branch. +10. After you submit the PR, verify that all [status checks](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks) are passing + +```markdown +$ git commit -m "A brief summary of the commit +> +> A paragraph describing what changed and its impact." +``` + + + +We encourage you to contribute and help make the library better for the community. Got questions? send us a [message](https://bit.ly/34Vkzcg). + +Thank you. + +The Flutterwave team 🦋 From ae3498ef496207502b1a729291dd78792102196e Mon Sep 17 00:00:00 2001 From: Cornelius Ashley-Osuzoka <59456456+corneliusyaovi@users.noreply.github.com> Date: Sat, 8 Apr 2023 02:28:15 +0100 Subject: [PATCH 2/4] Add redirect to support forum --- .github/ISSUE_TEMPLATE/config.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 0000000..c72eb33 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,5 @@ +blank_issues_enabled: false +contact_links: + - name: Developer Support Forum + url: https://forum.flutterwave.com + about: If you're having general trouble with your integration, Kindly contact our support team. From 77fd11bd890d7965819855d31a32d206174e3d6e Mon Sep 17 00:00:00 2001 From: Cornelius Ashley-Osuzoka <59456456+corneliusyaovi@users.noreply.github.com> Date: Sat, 8 Apr 2023 02:30:24 +0100 Subject: [PATCH 3/4] Add issue template --- .github/ISSUE_TEMPLATE/bug_report.md | 37 ++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000..a01a5be --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,37 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + +Have you read our [Code of Conduct](https://github.com/Flutterwave/PHP/blob/master/CONTRIBUTING.md)? By filing an Issue, you are expected to comply with it, including treating everyone with respect. + +# Description + + +# Steps to Reproduce + +1. +2. +3. + +## Expected behaviour + + +## Actual behaviour + + +## Reproduces how often + + +# Configuration +- API Version: +- Environment: +- Browser: +- Language: + +# Additional Information + From c51aa393e70bb6af24b860c7954d93a3e8563427 Mon Sep 17 00:00:00 2001 From: Osahenrumwen Aigbogun <54501513+leonardosahon@users.noreply.github.com> Date: Thu, 1 Feb 2024 19:44:29 +0100 Subject: [PATCH 4/4] Update Configure.php When a custom `env` variable is created, the bootstrap method was still trying to find the default env keys. With this new addition, if a user has used the `PackageConfig::setUp` method already to set their custom `env` variables, bootstrap would not have assume `self::$config` is not set again. --- src/Traits/Setup/Configure.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Traits/Setup/Configure.php b/src/Traits/Setup/Configure.php index 981fea9..0e5882c 100644 --- a/src/Traits/Setup/Configure.php +++ b/src/Traits/Setup/Configure.php @@ -12,7 +12,7 @@ trait Configure { public static function bootstrap(?ConfigInterface $config = null): void { - if (\is_null($config)) { + if (\is_null($config) && \is_null(self::$config)) { include __DIR__ . '/../../../setup.php'; if ('composer' === $flutterwave_installation) {