Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex-hyperparameters-wandb-project #37

Open
giuseppeambrosio97 opened this issue Dec 27, 2024 · 0 comments
Open

regex-hyperparameters-wandb-project #37

giuseppeambrosio97 opened this issue Dec 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@giuseppeambrosio97
Copy link
Contributor

Inconsistency in wandb_project Validation Pattern

Description

I notice a potential inconsistency between the regex pattern and the error message in the wandb_project validator:

@field_validator("wandb_project")
def validate_wandb_project(cls, value):
    if value is not None:
        # Define a regex pattern to match valid characters
        if not re.match(r"^[\w.-/]+$", value):
            raise ValueError(
                "Wandb project name must only contain characters, dashes, underscores, and dots."
            )
    return value

Questions for Clarification

  1. The error message states that only "characters, dashes, underscores, and dots" are allowed
  2. However, the regex pattern ^[\w.-/]+$ also allows forward slashes (/)
  3. Should forward slashes be permitted in Wandb project names?

Next Steps

  • Confirmation needed on whether forward slashes should be part of valid Wandb project names
  • Based on the answer, we can update either:
    • The regex pattern to exclude slashes
    • Or the error message to include slashes as valid characters

@CuriousDolphin Could you clarify the intended behavior?

@giuseppeambrosio97 giuseppeambrosio97 self-assigned this Dec 27, 2024
@giuseppeambrosio97 giuseppeambrosio97 added bug Something isn't working help wanted Extra attention is needed labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant