Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nesting of method timers #361

Open
GeertvanHorrik opened this issue May 25, 2021 · 1 comment
Open

Nesting of method timers #361

GeertvanHorrik opened this issue May 25, 2021 · 1 comment

Comments

@GeertvanHorrik
Copy link
Member

GeertvanHorrik commented May 25, 2021

Where it is clear that the below content has not read, the issue is likely to be closed with "please read the template". Please don't take offense at this. It is simply a time management decision. When someone raises an issue, without reading the template, then often too much time is spent going back and forth to obtain information that is outlined below.

You should already be a Patron

We are a patron

Is the proposal related to a problem

We have a lot of timings, and are trying to figure out performance measurements. This results in a lot of "nested timings", e.g.:

Method X took '23 ms'
Method Y took '25 ms'
Method Z took '27 ms'

In this case, it's hard to see why Z takes 27, but most time is taken by X.

A proposal would be to have an (optional) scope manager that checks the depth of a method timer. This could result in:

    Method X took '23 ms'
  Method Y took '25 ms'
Method Z took '27 ms'

Describe the solution

This would be an optional feature (disabled by default).

Happy to implement this myself as a PR.

@OFark
Copy link

OFark commented Feb 2, 2023

I came here looking to suggest this, so I could hierarchy my timings. I was going to suggest adding [CallerMemberName] to the method parameters so we could track what called the method in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants