From 59605c2eac50a32b96e6b6bd6138e6555b28bb48 Mon Sep 17 00:00:00 2001
From: ryanbas21 <ryanbas21@gmail.com>
Date: Fri, 6 Dec 2024 15:20:25 -0700
Subject: [PATCH] chore: fix-typings

fixed action collector type to be more clear of intent
---
 .../davinci-client/src/lib/collector.types.ts | 34 +++++--------------
 1 file changed, 9 insertions(+), 25 deletions(-)

diff --git a/packages/davinci-client/src/lib/collector.types.ts b/packages/davinci-client/src/lib/collector.types.ts
index 1292e0a50..f1ba2d9d6 100644
--- a/packages/davinci-client/src/lib/collector.types.ts
+++ b/packages/davinci-client/src/lib/collector.types.ts
@@ -61,19 +61,6 @@ export type ActionCollectorTypes =
   | 'SocialLoginCollector'
   | 'ActionCollector';
 
-export interface ActionCollectorNoUrl<T extends ActionCollectorTypes> {
-  category: 'ActionCollector';
-  error: string | null;
-  type: T;
-  id: string;
-  name: string;
-  output: {
-    key: string;
-    label: string;
-    type: string;
-  };
-}
-
 type ActionCollectorOutputTypes =
   | {
       key: string;
@@ -86,7 +73,8 @@ type ActionCollectorOutputTypes =
       label: string;
       type: string;
     };
-export interface ActionCollectorWithUrl<T extends ActionCollectorTypes> {
+
+export interface ActionCollector<T extends ActionCollectorTypes> {
   category: 'ActionCollector';
   error: string | null;
   type: T;
@@ -95,18 +83,14 @@ export interface ActionCollectorWithUrl<T extends ActionCollectorTypes> {
   output: ActionCollectorOutputTypes;
 }
 
-export type ActionCollector<T extends ActionCollectorTypes> =
-  | ActionCollectorNoUrl<T>
-  | ActionCollectorWithUrl<T>;
-
 export type ActionCollectors =
-  | ActionCollectorWithUrl<'SocialLoginCollector'>
-  | ActionCollectorNoUrl<'ActionCollector'>
-  | ActionCollectorNoUrl<'FlowCollector'>
-  | ActionCollectorNoUrl<'SubmitCollector'>;
+  | ActionCollector<'SocialLoginCollector'>
+  | ActionCollector<'ActionCollector'>
+  | ActionCollector<'FlowCollector'>
+  | ActionCollector<'SubmitCollector'>;
 
-export type FlowCollector = ActionCollectorNoUrl<'FlowCollector'>;
+export type FlowCollector = ActionCollector<'FlowCollector'>;
 export type PasswordCollector = SingleValueCollectorNoValue<'PasswordCollector'>;
 export type TextCollector = SingleValueCollectorWithValue<'TextCollector'>;
-export type SocialLoginCollector = ActionCollectorWithUrl<'SocialLoginCollector'>;
-export type SubmitCollector = ActionCollectorNoUrl<'SubmitCollector'>;
+export type SocialLoginCollector = ActionCollector<'SocialLoginCollector'>;
+export type SubmitCollector = ActionCollector<'SubmitCollector'>;