Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in license deactivation notice #782

Open
andrewjmead opened this issue Jan 31, 2025 · 0 comments
Open

Typo in license deactivation notice #782

andrewjmead opened this issue Jan 31, 2025 · 0 comments

Comments

@andrewjmead
Copy link

andrewjmead commented Jan 31, 2025

When deactivating a license from the Freemius admin page, I see the following notice:

Image

It starts with O.K which should probably be OK or something like OK!. This comes from:

https://github.com/Freemius/wordpress-sdk/blob/master/includes/class-freemius.php#L21709

The activation messages started with Yee-Haw! Your license... so something like OK! Your license... with an exclamation mark would match that.

Thanks for considering this change. I understand we can tweak it with override_i18n, but I still wanted to bring it up as a possible change to the SDK itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant