Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing skip turn icon above character [bounty: 6 XTR] #2583

Closed
DreadKnight opened this issue May 21, 2024 · 2 comments
Closed

missing skip turn icon above character [bounty: 6 XTR] #2583

DreadKnight opened this issue May 21, 2024 · 2 comments
Assignees
@Joywin2412
Labels
coding This issue requires some programming easy Good place to start if you're a new developer input Deals with hotkeys, interaction & accessibility visuals Various things that easily catch the eye
Milestone
0.5 - Chimera

Comments

@DreadKnight
Copy link
Member

DreadKnight commented May 21, 2024 •
edited
Loading

When a unit doesn't have any action left, hovering on it should show the skip turn icon above the "Skip Turn" text, as implemented, issue #2536 and PR #2558, though it's currently broken in Firefox browser, no icon displayed in the frame above the unit and there's also a frame in the upper right side of the game, as seen in the screenie:

Screenshot_20240521_142037
@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye easy Good place to start if you're a new developer input Deals with hotkeys, interaction & accessibility labels May 21, 2024
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone May 21, 2024
@DreadKnight DreadKnight mentioned this issue May 21, 2024
Merged
@Joywin2412
Copy link
Contributor

I can try this issue. Can you please assign this to me?

@DreadKnight
Copy link
Member Author

I can try this issue. Can you please assign this to me?

@Joywin2412 Heya! Sure thing, go for it. Will assign when at my desk. 2 weeks soft deadline 🐻

@Joywin2412 Joywin2412 mentioned this issue Aug 8, 2024
Merged
@DreadKnight DreadKnight changed the title missing skin turn icon above character [bounty: 6 XTR] missing skip turn icon above character [bounty: 6 XTR] Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joywin2412 Joywin2412

Labels
coding This issue requires some programming easy Good place to start if you're a new developer input Deals with hotkeys, interaction & accessibility visuals Various things that easily catch the eye
Projects
None yet
Milestone
0.5 - Chimera
Development

No branches or pull requests
2 participants
@DreadKnight @Joywin2412