Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branding missing when in iframe [bounty: 4 XTR] #2615

Closed
DreadKnight opened this issue Aug 24, 2024 · 8 comments
Closed

branding missing when in iframe [bounty: 4 XTR] #2615

DreadKnight opened this issue Aug 24, 2024 · 8 comments
Labels
bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer invalid The issue is not from the project or a "won't fix" marketing Spreading the word about the project visuals Various things that easily catch the eye
Milestone
0.5 - Chimera

Comments

@DreadKnight
Copy link
Member

While pressing shift or hovering the round marker from the unit queue, the project logo (Ancient Beast text) doesn't display when the game is embedded via an iframe.

https://ancientbeast.com (embed via iframe) versus https://beta.ancientbeast.com (no embed).
@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye marketing Spreading the word about the project easy Good place to start if you're a new developer bounty Some amount of our token, XatteR, is offered labels Aug 24, 2024
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone Aug 24, 2024
@DreadKnight DreadKnight mentioned this issue Aug 24, 2024
Merged
@nohaibogdan1
Copy link
Contributor

@DreadKnight I will pick this one

@DreadKnight
Copy link
Member Author

@nohaibogdan1 Alrighty, go for it! 🐻

@nohaibogdan1
Copy link
Contributor

@DreadKnight I cannot reproduce it, sent you a screenrecord on discord

@DreadKnight
Copy link
Member Author

@DreadKnight I cannot reproduce it, sent you a screenrecord on discord

@nohaibogdan1 Yeah, apparently by editing that attribute you actually end up bypassing the bug. Perhaps you can reproduce by having a local html webpage and just have a similar iframe in it with some auto deployed game server for the branch tested, you can find a "View deployment" button a bit after pushing a PR here on Github which leads you to the proper link to use, but note that the subdomain changes with each new push.

@nohaibogdan1
Copy link
Contributor

@DreadKnight Still cannot reproduce it . I tried with this:

<!DOCTYPE html>
<html>
    <body>
        <iframe 
          id="game" 
          name="game" 
          src="https://ancientbeast-git-fork-nohaibogdan1-fix-logo-d73687-freezingmoon.vercel.app/" 
          style="border: 4px ridge; border-color: grey; width: 934px; height: 525px;" 
          seamless="" 
          sandbox="allow-same-origin allow-forms allow-scripts allow-popups" 
          webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>
    </body>
</html>

How do you reproduce it ?

@DreadKnight
Copy link
Member Author

@DreadKnight Still cannot reproduce it . I tried with this:

<!DOCTYPE html>
<html>
    <body>
        <iframe 
          id="game" 
          name="game" 
          src="https://ancientbeast-git-fork-nohaibogdan1-fix-logo-d73687-freezingmoon.vercel.app/" 
          style="border: 4px ridge; border-color: grey; width: 934px; height: 525px;" 
          seamless="" 
          sandbox="allow-same-origin allow-forms allow-scripts allow-popups" 
          webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>
    </body>
</html>

How do you reproduce it ?

https://github.com/FreezingMoon/AncientBeast-Website/blob/master/index.php#L33

@DreadKnight
Copy link
Member Author

@nohaibogdan1 Heya! Any progress with this one? Usually 2 weeks soft deadline 🐻

@DreadKnight
Copy link
Member Author

Invalid bug, the patch wasn't in v0.4, which is currently on Ancient Beast website's homepage, similarly to what happened regarding #2618 - I've tested against beta version and works fine.

@DreadKnight DreadKnight added the invalid The issue is not from the project or a "won't fix" label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer invalid The issue is not from the project or a "won't fix" marketing Spreading the word about the project visuals Various things that easily catch the eye
Projects
None yet
Milestone
0.5 - Chimera
Development

No branches or pull requests
2 participants
@DreadKnight @nohaibogdan1