Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not following Theme #9

Closed
SirusCodes opened this issue Mar 25, 2021 · 8 comments
Closed

Icons not following Theme #9

SirusCodes opened this issue Mar 25, 2021 · 8 comments

Comments

@SirusCodes
Copy link

In 1.0.0 Icons are not following color from theme and shows ThemeData.disabledColor

AnimatedIconButton(
    size: 25,
    animationController: _iconController,
    icons: const [
        AnimatedIconItem(icon: Icon(Icons.share)),
        AnimatedIconItem(icon: Icon(Icons.close_rounded)),
    ],
),
@Frezyx Frezyx added bug Something isn't working help wanted Extra attention is needed labels Mar 28, 2021
@Frezyx
Copy link
Owner

Frezyx commented Mar 28, 2021

Hello @SirusCodes 👋🏻
Big thanks for reporting this !
I will check this bug soon.

@SirusCodes
Copy link
Author

Thanks a lot ❤️

@Frezyx Frezyx pinned this issue May 6, 2021
@jlnrrg
Copy link
Contributor

jlnrrg commented May 24, 2021

@SirusCodes which would be the ThemeData you'd expect it to follow?
I personally use the AnimatedIconButton as a FloatingActionButton replacement, but I doubt that this is true for everyone. So it would be great if you could specify which Theme.of(context). <- you'd expect.

@SirusCodes
Copy link
Author

@SirusCodes which would be the ThemeData you'd expect it to follow?
I personally use the AnimatedIconButton as a FloatingActionButton replacement, but I doubt that this is true for everyone. So it would be great if you could specify which Theme.of(context). <- you'd expect.

I don't have any problem with using Theme.of(context) but new update has some changes which changed the expected behaviour.

@jlnrrg
Copy link
Contributor

jlnrrg commented May 25, 2021

As I basicly made a lot of major improvements without the state of the art in mind, my question is what the expected behaviour is.
Also there are multiple entries under Theme. of(contex)
Themes for Elevatedbutton or Outlinedbutton, to name a few.

@SirusCodes
Copy link
Author

I expect it to be of default Icon color as in flutter docs

@Frezyx Frezyx removed the help wanted Extra attention is needed label Jun 4, 2021
@Frezyx
Copy link
Owner

Frezyx commented Jun 4, 2021

Hello @SirusCodes ! ✋🏻
I was able to find time for this question only now.
Sorry for your waiting

Icons take this color due to the fact that you do not pass onPressed callback.
You can pass this field and icon will become the same color as in the theme.
This practice is standard for IconButton widgets.

@Frezyx Frezyx removed the bug Something isn't working label Jun 4, 2021
@SirusCodes
Copy link
Author

Ohh @Frezyx I will verify this, thanks for your time.

@Frezyx Frezyx closed this as completed Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants