Fix all compile warnings

[stefan-tb]

Ideally, one should fix all the compile warnings. Especially all "obsolete" warnings in the CADabilty code base itself should be solved by shaping CADability legacy code into the desired patterns as a migration reference for other contributors.

[ChrisClems]

Would it be helpful if I started tackling some of the easy ones? I looked through a handful of them and it looks like most of them are unused fields, events, and variables that date back to the first commit.

[dsn27]

That would be helpful, but please don’t spend too much time on it.
I believe there are larger priorities to focus on.

[ChrisClems]

It's really just an excuse to dig into the codebase and learn more about it. I have a couple big projects in the works that I'll be using this for so I'd like to contribute but I don't have a ton of experience collaborating with other programmers so I'd like to ease into it. Cleaning up unused variables seems like an easy win and I can learn more about the structure and do some translations in the process.

[dsn27]

Your help is really appreciated. Thanks a lot for spending time on this project.

[stefan-tb]

As the one who opened this: removing private variables is fine. Doing more, especially working on the [obsolete] parts gets tricky quickly. The code base is half-way trough a refactoring which was never finished. That said, any decrease in warnings is highly appreciated.

We ourselves might be able to contribute a substantial rewrite of the UI and rendering parts down the line, splitting Math and UI entirely. I really want to see this fly.

[dsn27]

• CS DialogDebuggerVisualizer.DialogDebuggerVisualizer()' is obsolete: 'Visualizers that target Visual Studio 17.6 or newer should use the other DialogDebuggerVisualizer overload and use a non-legacy formatting policy for improved security. Fix Visualizer for Visual Studio >17.6 #192
• Remove unused fields CS0169
• Remove unused variables CS0219
• Fix CS0219 The variable is assigned but its value is never used
• Fix CS0162 Unreachable code detected
• Fix CS3005 Identifier 'identifier' differing only in case is not CLS-compliant
• Fix CS0067 The event is never used
• Fix CS0108 'member1' hides inherited member 'member2'. Use the new keyword if hiding was intended.
• Fix CS0114 'function1' hides inherited member 'function2'.
• Fix CS0618 'member' is obsolete: 'text'
• Fix CS0649 Field is never assigned to, and will always have its default value 0 or null

Fixing these issues shouldn't have a big impact on the program itself and are easy to fix.

• CS0618 Remove obsolete properties.
  This is going to be hugh. Every single Property/Function has to be checked.

• Is the replacement working properly?

• Are there parts of the program that still rely on this Property/Function?

We should probably create an issue and PR for each single Property/Function that will be replaced.

12th Dec - 970 Warnings
20th Dec - 761 Warnings
22th Jan - 747 Warnings