From 57ba412d813bb150b8a4ff9b65d4513725e31a1d Mon Sep 17 00:00:00 2001 From: Hlavtox Date: Wed, 20 Nov 2024 12:52:06 +0100 Subject: [PATCH] Fix PHP 8.4 deprecation notices --- Extractor/ExposedRoutesExtractor.php | 2 +- Response/RoutesResponse.php | 2 +- Serializer/Denormalizer/RouteCollectionDenormalizer.php | 4 ++-- Serializer/Normalizer/RouteCollectionNormalizer.php | 4 ++-- Serializer/Normalizer/RoutesResponseNormalizer.php | 4 ++-- Tests/Controller/ControllerTest.php | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Extractor/ExposedRoutesExtractor.php b/Extractor/ExposedRoutesExtractor.php index a2d7d6f..1c8e475 100644 --- a/Extractor/ExposedRoutesExtractor.php +++ b/Extractor/ExposedRoutesExtractor.php @@ -143,7 +143,7 @@ public function getScheme(): string /** * {@inheritDoc} */ - public function getCachePath(string $locale = null): string + public function getCachePath(?string $locale = null): string { $cachePath = $this->cacheDir.DIRECTORY_SEPARATOR.'fosJsRouting'; if (!file_exists($cachePath)) { diff --git a/Response/RoutesResponse.php b/Response/RoutesResponse.php index 9d18aac..332217b 100644 --- a/Response/RoutesResponse.php +++ b/Response/RoutesResponse.php @@ -21,7 +21,7 @@ class RoutesResponse public function __construct( protected ?string $baseUrl = null, - RouteCollection $routes = null, + ?RouteCollection $routes = null, protected ?string $prefix = null, protected ?string $host = null, protected ?string $port = null, diff --git a/Serializer/Denormalizer/RouteCollectionDenormalizer.php b/Serializer/Denormalizer/RouteCollectionDenormalizer.php index 741c0c0..53ef704 100644 --- a/Serializer/Denormalizer/RouteCollectionDenormalizer.php +++ b/Serializer/Denormalizer/RouteCollectionDenormalizer.php @@ -22,7 +22,7 @@ class RouteCollectionDenormalizer implements DenormalizerInterface /** * {@inheritDoc} */ - public function denormalize(mixed $data, string $type, string $format = null, array $context = []): RouteCollection + public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): RouteCollection { $collection = new RouteCollection(); @@ -45,7 +45,7 @@ public function denormalize(mixed $data, string $type, string $format = null, ar /** * {@inheritDoc} */ - public function supportsDenormalization(mixed $data, string $type, string $format = null, array $context = []): bool + public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool { if (!is_array($data)) { return false; diff --git a/Serializer/Normalizer/RouteCollectionNormalizer.php b/Serializer/Normalizer/RouteCollectionNormalizer.php index 657ccf2..eef523c 100644 --- a/Serializer/Normalizer/RouteCollectionNormalizer.php +++ b/Serializer/Normalizer/RouteCollectionNormalizer.php @@ -24,7 +24,7 @@ class RouteCollectionNormalizer implements NormalizerInterface /** * {@inheritDoc} */ - public function normalize(mixed $object, string $format = null, array $context = []): array + public function normalize(mixed $object, ?string $format = null, array $context = []): array { $collection = []; @@ -47,7 +47,7 @@ public function normalize(mixed $object, string $format = null, array $context = /** * {@inheritDoc} */ - public function supportsNormalization(mixed $data, string $format = null, array $context = []): bool + public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool { return $data instanceof RouteCollection; } diff --git a/Serializer/Normalizer/RoutesResponseNormalizer.php b/Serializer/Normalizer/RoutesResponseNormalizer.php index 46c6a63..5586916 100644 --- a/Serializer/Normalizer/RoutesResponseNormalizer.php +++ b/Serializer/Normalizer/RoutesResponseNormalizer.php @@ -24,7 +24,7 @@ class RoutesResponseNormalizer implements NormalizerInterface /** * {@inheritDoc} */ - public function normalize(mixed $object, string $format = null, array $context = []): array + public function normalize(mixed $object, ?string $format = null, array $context = []): array { return [ 'base_url' => $object->getBaseUrl(), @@ -40,7 +40,7 @@ public function normalize(mixed $object, string $format = null, array $context = /** * {@inheritDoc} */ - public function supportsNormalization(mixed $data, string $format = null, array $context = []): bool + public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool { return $data instanceof RoutesResponse; } diff --git a/Tests/Controller/ControllerTest.php b/Tests/Controller/ControllerTest.php index 9ef10fe..9183b58 100644 --- a/Tests/Controller/ControllerTest.php +++ b/Tests/Controller/ControllerTest.php @@ -243,7 +243,7 @@ public function testExposeDomain(): void $this->assertEquals('{"base_url":"","routes":{"homepage":{"tokens":[["text","\/"]],"defaults":[],"requirements":[],"hosttokens":[],"methods":[],"schemes":[]},"admin_index":{"tokens":[["text","\/admin"]],"defaults":[],"requirements":[],"hosttokens":[],"methods":[],"schemes":[]},"admin_pages":{"tokens":[["text","\/admin\/path"]],"defaults":[],"requirements":[],"hosttokens":[],"methods":[],"schemes":[]},"blog_index":{"tokens":[["text","\/blog"]],"defaults":[],"requirements":[],"hosttokens":[["text","localhost"]],"methods":[],"schemes":[]},"blog_post":{"tokens":[["variable","\/","[^\/]++","slug"],["text","\/blog"]],"defaults":[],"requirements":[],"hosttokens":[["text","localhost"]],"methods":[],"schemes":[]}},"prefix":"","host":"","port":null,"scheme":"","locale":"en"}', $response->getContent()); } - private function getExtractor(RouteCollection $exposedRoutes = null, $baseUrl = '') + private function getExtractor(?RouteCollection $exposedRoutes = null, $baseUrl = '') { if (null === $exposedRoutes) { $exposedRoutes = new RouteCollection();