Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enchantment Descriptions & the option to Disable Armor Trims #14

Open
PoseironDire opened this issue Dec 25, 2024 · 2 comments
Open

Comments

@PoseironDire
Copy link

It would be nice to have the option to disable the armor trims because some mods allow for them to be applied to elytras, horse and wolf armors, when applying modded ones the textures are missing.

I realized that my resource pack made trimmed horse armors look glitched so I skipped on that mod, though I still have the mod for elytra trims (Customizable Elytra), when I play on my own it is not an issue as I can just remember that it does not work to apply them to those other pieces, however when playing with other friends it will be a pain to explain that to them al.

I have another small and easy suggestion: Give the 2 enchantments descriptions in the lang file so that mods that display that information can teach players using this mod about those enchantments. I actually still don't know what they do... x)

@Lufurrius
Copy link
Contributor

The enchantments will have descriptions come the next release, likely with 1.1 - it's already a thing on the main branch.

As far as the missing textures go, you can actually quite easily add compat via a resourcepack. Look at each mod in question's assets, in particular any atlasses and make sure that each texture and permutation is registered.
If you can provide the exact mods in question, I'll look into providing compatability on our end where feasible. Fair chance the pet armour trims won't be something to considder as from memory the implementations of those I've seen wheren't the best and where quite crap to work with, with the project being closed source and under ARR.

@PoseironDire
Copy link
Author

PoseironDire commented Dec 25, 2024

Glad to hear that :D The only mod I use that expands armor trim usage is Customizable Elytra, if you make textures for that mod I would really like that!

EDIT: Also Elytra Trims is another mod that adds trims to elytra, thought it seems like the creator of that mod has an addon that adds missing textures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants