Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepts empty password on new wallet and account creation #176

Open
manan-m-shah opened this issue May 2, 2024 · 4 comments
Open

Accepts empty password on new wallet and account creation #176

manan-m-shah opened this issue May 2, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@manan-m-shah
Copy link

Not sure if it's intentional, but the commands below are accepting empty passwords.

forc wallet new
forc wallet account new

Can quickly patch this if required.

@kayagokalp
Copy link
Member

I think we can disallow empty passwords as a security measure. cc @FuelLabs/tooling for ideatation

@kayagokalp kayagokalp added the enhancement New feature or request label May 2, 2024
@kayagokalp
Copy link
Member

@manan-m-shah are you still interested in implementing this? I think we want this implemented, and will likely look into it in coming weeks. If you want to take a shot, go for it!

@sdankel
Copy link
Member

sdankel commented Jun 13, 2024

I agree, this would be a good security measure. This code changes will be in https://github.com/FuelLabs/forc-wallet

@zees-dev
Copy link
Contributor

zees-dev commented Dec 8, 2024

For better UX, if the user continues to use empty-password when being prompted upon wallet creation; the loop should display a helpful note stating that the non-empty password-requirement can be overriden with a flag.

@sdankel sdankel added the good first issue Good for newcomers label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants