Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity-check gtf opcodes #1499

Closed
MitchTurner opened this issue Nov 20, 2023 · 1 comment
Closed

Sanity-check gtf opcodes #1499

MitchTurner opened this issue Nov 20, 2023 · 1 comment
Assignees

Comments

@MitchTurner
Copy link
Member

Following #1386

Might not need to create a benchmark for every gtf opcode, but rather choose a good candidate for worst-case scenario.

Specifically, the opcodes that get metadata from inputs/outputs can take longer if there are more inputs/outputs. We might be able to choose a worst-case opcode and overcharge for the others since gtf isn't called many times in a single script.

@MitchTurner MitchTurner self-assigned this Nov 20, 2023
xgreenx added a commit that referenced this issue Nov 22, 2023
#1499

vm benches:
```
gtf/gtf                
time:   [208.43 ns 208.99 ns 209.60 ns]
```

sanity benches:
```
block target estimation/other/gtf
time:   [65.877 ms 66.094 ms 66.323 ms]
```

---------

Co-authored-by: xgreenx <[email protected]>
@xgreenx
Copy link
Collaborator

xgreenx commented Nov 22, 2023

Closed by #1503

@xgreenx xgreenx closed this as completed Nov 22, 2023
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
FuelLabs/fuel-core#1499

vm benches:
```
gtf/gtf                
time:   [208.43 ns 208.99 ns 209.60 ns]
```

sanity benches:
```
block target estimation/other/gtf
time:   [65.877 ms 66.094 ms 66.323 ms]
```

---------

Co-authored-by: xgreenx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants