Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leading zeros in Tip field #1352

Closed
HoTandy opened this issue Jun 5, 2024 · 0 comments · Fixed by #1481
Closed

Leading zeros in Tip field #1352

HoTandy opened this issue Jun 5, 2024 · 0 comments · Fixed by #1481
Assignees
@helciofranco
Labels
bug Something isn't working

Comments

@HoTandy
Copy link
Contributor

HoTandy commented Jun 5, 2024 •
edited
Loading

As can be shown in the attached video, I can add leading zeros into the Tip edit field, one I enter a decimal point, then all the zeros except the first one are deleted.

leading.zeros.mov

It shouldn't be possible to enter leading zeros into this field.

As a side-effect, when clicking backspace on one of the many leading zeros, 2 zeros are deleted and not one, see the vid below.

deleting.2.chars.mov

Once the leading zeros problem is resolved, the deletion problem should also be solved.
@HoTandy HoTandy added the bug Something isn't working label Jun 5, 2024
@HoTandy HoTandy mentioned this issue Jun 5, 2024
Merged
@helciofranco helciofranco linked a pull request Jun 5, 2024 that will close this issue
feat: add an option to send custom gas limit when making transfers #1318
Merged
@helciofranco helciofranco self-assigned this Jun 5, 2024
@helciofranco helciofranco added the p1 label Jun 5, 2024
@helciofranco helciofranco removed a link to a pull request Jun 5, 2024
feat: add an option to send custom gas limit when making transfers #1318
Merged
@helciofranco helciofranco removed their assignment Jun 5, 2024
@LuizAsFight LuizAsFight added p2 and removed p1 labels Jun 19, 2024
@LuizAsFight LuizAsFight removed the p2 label Sep 14, 2024
@helciofranco helciofranco mentioned this issue Sep 17, 2024
Merged
helciofranco added a commit that referenced this issue Sep 18, 2024
@helciofranco
fix: leading zeros in the inputs (#1481)
926a64f 
- Closes #1352
- Closes #1353
- Closes #1355

---

| 📷  Demo |
| --- |
| <video
src="https://github.com/user-attachments/assets/46fda902-9713-4007-b799-00197d6cbe75"
/> |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helciofranco helciofranco

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: leading zeros in the inputs FuelLabs/fuels-wallet
4 participants
@helciofranco @rodrigobranas @LuizAsFight @HoTandy