Annoying ecbuild warning message from ecbuild

[mathomp4]

This is not really important (and is part of #7) but I thought I'd ask @tclune and @aerorahul about it.

During the cmake step we see:

CMake Warning at @cmake/@ecbuild/cmake/ecbuild_log.cmake:158 (message):
  WARN - The linker does not support $ORIGIN at link-time, disabling
  dynamic symbol check when linking against shared libraries
Call Stack (most recent call first):
  @cmake/@ecbuild/cmake/ecbuild_check_os.cmake:295 (ecbuild_warn)
  @cmake/@ecbuild/cmake/ecbuild_system.cmake:245 (include)
  @cmake/esma.cmake:15 (include)
  CMakeLists.txt:33 (include)

Now, we can set ECBUILD_LOG_LEVEL=ERROR and we'd not see this. The question is: Should we? @aerorahul Does the JEDI project have an official thought on what level of ecbuild logging to use?

[tclune]

No - I don't think we should. I just did a PR which is going to be very noisy with WARNING and want to use those to go (gradually) update all the places where things have gotten deprecated. I suppose we could make it the default for regular users though.

Hiding DEBUG and INFO level is probably fine by default.

@aerorahul Your opinion?

[aerorahul]

@mathomp4 the -DECBUILD_LOG_LEVEL variable is typically set to its default value (OFF).
Anyways, the log is to debug/print info within ecbuild via MESSAGE command. It is not a true CMake debug.
We (I) only use the debug when I am adding my own FindXYZ.cmake or updating a macro. I don't think the JEDI project goes into ecbuild logging as part of their everyday development.

[tclune]

I don't have a really strong opinion, but OFF seems like it would hide issues for quite some time. If WARNINGs don't really matter, why did anyone bother with the logic in the first place ...

[mathomp4]

Or, I suppose why

@mathomp4 the -DECBUILD_LOG_LEVEL variable is typically set to its default value (OFF).
Anyways, the log is to debug/print info within ecbuild via MESSAGE command. It is not a true CMake debug.

Actually, it looks like the default value is actually INFO:

if( NOT DEFINED ECBUILD_LOG_LEVEL )
  set(ECBUILD_LOG_LEVEL ${ECBUILD_INFO})

And INFO is the level just above DEBUG so we get most everything.