Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make a new release for Adjoint patch #20

Open
bena-nasa opened this issue May 7, 2021 · 2 comments
Open

Should we make a new release for Adjoint patch #20

bena-nasa opened this issue May 7, 2021 · 2 comments
Assignees

Comments

@bena-nasa
Copy link

When testing GEOSgcmPert.x with the geos/2019.01.02+noaff.6 it was found the executable was crashing.
@mathomp4 recognized the crash and had a branched that fixed it after merge our current version into that branch. The branch is: https://github.com/GEOS-ESM/FMS/tree/feature/mathomp4%2Fenable-efp-in-sum_ad

Assuming this has no impact on anything else we should make a new release.

@bena-nasa
Copy link
Author

I tested this with AGCM run and MOM6 run. Both were zero diff.

@mathomp4
Copy link
Member

I see no reason not too. I'll do a double check myself and then maybe as a "final" check, we can have @sanAkel do a MOM6 run by a real expert. That is, make sure it doesn't affect the MOM6 output that I have no idea how to enable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants