-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update regrid.pl to include MOM6 ocean grids and new location for MOM5 grids. #210
Comments
@bena-nasa, @mathomp4, @atrayano, @tclune, @GEOS-ESM/gmao-si-team, appreciate your help with this! Specifically with the |
We need logic, which distinguishes between MOM5 and MOM6. I don't know how to implement this in perl. |
We might have to do some "ugliness".
|
Or I suppose, leave |
Note: we are not trying to regrid MOM5/6 restarts here, we want to regrid atmosphere and surface restarts. Surface restarts are tile restarts and we need to point regrid.pl to correct tile file, e.g.
Regridding of coupled restarts is essentially no different than regridding of AMIP restarts. "Icarus-NLv3" in the above example is a version of land boundary conditions, which has to be a variable. Then there are 3 other variables, ocean model version (MOM5/MOM6, later MIT ocean is possible), atmosphere resolution (c180x6 in the above example) and ocean resolution (1/4 degree in the above example), all this information should point to a correct tile file. The rest of the regridding logic is the same as in AMIP case afaik. |
@yvikhlya I'm trying to look at cleaning up Or are the MOM5 files in the new location the same as the files that were in the old location? Or should we just no longer support any of the older tile? I'm just wondering how to handle the new files and if I need to keep support for the older ones. |
The idea is to consolidate boundary conditions and include coupled model support. Right now the new location has only Icarus-NLv3 bcs, because I am not sure what to do with old bcs. We can't abandon support of older tile files because S2Sv2/v3 use them, so they should stay where they are right now, but from now on it would be good to handle different versions of bcs some better way than we do now. As for regrid.pl, I would suggest not to worry about old tile files for now, but to add support of new tile files in such a way that bcs version, ocean model (MOM5/MOM6/MIT) and resolution are variables. We need a straightforward way to generate restarts for our S2Sv4 and other experiments. @tclune @amolod please share your opinion. |
@yvikhlya When you have a chance, can you please make the topography symlinks in these new directories? |
@yvikhlya Thanks. I just gave it a try with my test
|
Oh, that is true, MERRA-2 restarts did not work and I used m2ocean restarts. |
@sanAkel Well, I'm not thinking it'll be good science. I just wondered if they'd run. As in, the model doesn't die after a day. |
@mathomp4 for sure, the |
@mathomp4 We can't use MERRA2 restarts with coupled Jason model, because seaice_thermo restart is incompatible and it can't be bootstrapped or converted. For S2Sv4 model I took m2ocean restarts from My questions are:
@sanAkel Please comment if you see anything wrong. |
@yvikhlya I can't comment on the
@yvikhlya it would be good to note, for the record why:
|
@yvikhlya If you want to test what I have (even if it's not correct), you'll need to use my branch:
It's the only place I've put on my attempt to use your new files |
MERRA2 has old saltwater format. When I tried to regrid MERRA2 to S2Sv4, it split saltwater_internal into openwater_internal and seaicethermo_internal and the latter crashed the model. @zhaobin74 advised not to take seaicethermo_internal from MERRA2. |
Andrea had mentioned that @zhaobin74 might have a utility that can convert the seaice? Not sure |
Also, pinging @aoloso on this thread as he might be doing some of the |
It's not a good idea to convert AMIP (i.e. SimpleSeaice) seaicethermo restart to coupled as it lacks critical information, e.g. ice thickness. Coupled model needs to restart from proper sea ice volume such that any drift can be attributed to the model, not the initial condition. We have seen many examples of the bad initialization. I'd suggest regrid.pl should pick up MERRA-2 OCEAN restarts when it does regridding of seaicethermo restart.
|
It is AMIP SimpleSeaice restart, not the CICEColumnPhys.
It lacks information to properly represent sea ice volume and its spatial distribution.
It can not be bootstrapped just like other tile restarts, Land, Lake, Landice. |
@zhaobin74 Ah. Thanks. I know Andrea mentioned something called |
thanks @zhaobin74 |
@mathomp4, I did write such a converter years ago as a response to a very specific request. It has never been meant for general use. The bottom line is AMIP/MARRA-2 seaicethermo restart is a bad starting point for coupled, and we have many good ones sitting around. |
@mathomp4 I think I found a little bug here GMAO_Shared/GEOS_Util/post/regrid.pl Line 789 in 8b1df20
|
Sigh. oops. Yeah, the "power" of copy-paste. Let me fix that... |
@mathomp4 Also, mdlINocean is uninitialized at this point GMAO_Shared/GEOS_Util/post/regrid.pl Line 788 in 8b1df20
GMAO_Shared/GEOS_Util/post/regrid.pl Line 814 in 8b1df20
|
Okay. I think I fixed that. |
Okay some updates. I've pushed some changes. Now, it is a bit more exciting. There are now some questions about ocean models. So, I'm going to regrid some S2S restarts I found, a la:
to C24 MOM6. As I run regrid it asks:
Now the default here is
and after that it's as it is. Now it's still not smart. You have to know that MOM6 C24 for Icarus-NLv3 is allowed, but it's a first start. But in the end I get restarts as seen here:
and the resulting seaicethermo restart does have 23 variables instead of 13 |
Also, @yvikhlya, if you have a chance, can you copy all the "old" BCs you have in:
into the new place:
I see you have I suppose it would be good if you could put them in similar |
Hi Matt, my understanding is that |
@mathomp4 let me reach over teams. Thanks! |
Huh Okay. I was hoping to clean/remove these lines involving GMAO_Shared/GEOS_Util/post/regrid.pl Lines 106 to 125 in c2bbdae
I don't think they are dead code...but maybe? I could try commenting them out and regridding S2S to MOM6. If nothing is triggered, then it's dead code! 😄 |
It is a dead code from my point of view. I would clean this up if I understood perl a little bit better. |
@yvikhlya Well, that gives me a good reason to try removing it and seeing what happens! I'll report back soon |
Thanks Matt! |
@yvikhlya Actually it is not dead code. I spoke a bit with @bena-nasa and the regridding code needs both the input and output tile files and input/output topo files. And since I'm regridding from S2S restarts, we need the Ganymed stuff you have in As a test, I whipped up a skeleton bcs area here:
where I've symlinked your Icarus and Icarus-NLv3 directories as well as created a
In there I copied the files from:
into my
When I did this, and pointed So, if you have time, it might be worth making this tree for (Of course, don't delete the old ones since that would break all other regrid.pl out there.) |
Oh, I got it now. |
@mathomp4 I did copy your whole tree into |
@yvikhlya Okay, I see that you have the S2S BCs ( |
Reopened to fix |
Currently, regrid.pl looks for coupled tile files in:
and supports only following MOM5 configurations:
Recently, coupled model tile files were moved to
/discover/nobackup/projects/gmao/ssd/aogcm/atmosphere_bcs/Icarus-NLv3/MOM5
and/discover/nobackup/projects/gmao/ssd/aogcm/atmosphere_bcs/Icarus-Nlv3/MOM6
. Two MOM6 configuration were added72x36
and1440x1080
(the latter is not the same as MOM51440x1080
). More MOM6 configurations are possible in the future. We need regrid.pl script to be able to produce restarts for all these configurations.I am not an expert in perl, but I can start working on regrid.pl and probably need help from @bena-nasa.
The text was updated successfully, but these errors were encountered: