You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In adding type hinting for swell, we discovered that the implementation of Logger could be improved:
Implement Logger (from swell.utilities.logger) as an inherited class of logging.Logger. This would simplify annotations and make it possible for swell code to simply use logging.Logger where sufficient
This would resolve possible confusion in cases such as in slurm_test.py, which passes a logging.Logger object to SWELLError, where most other functions specifically expect a swell logger.
The text was updated successfully, but these errors were encountered:
In adding type hinting for swell, we discovered that the implementation of
Logger
could be improved:Logger
(fromswell.utilities.logger
) as an inherited class oflogging.Logger
. This would simplify annotations and make it possible for swell code to simply uselogging.Logger
where sufficientThis would resolve possible confusion in cases such as in
slurm_test.py
, which passes alogging.Logger
object toSWELLError
, where most other functions specifically expect a swelllogger
.The text was updated successfully, but these errors were encountered: