Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing #139

Open
2 tasks
SlowMo24 opened this issue Dec 6, 2023 · 1 comment
Open
2 tasks

Improve testing #139

SlowMo24 opened this issue Dec 6, 2023 · 1 comment
Labels
good first issue Good for newcomers testing Something needs testing

Comments

@SlowMo24
Copy link
Collaborator

SlowMo24 commented Dec 6, 2023

We currently use integration testing nearly everywhere but at the same time not properly.

  • swap integration test (using VCR) for unit-testing (testing only the method of concern) where possible.
  • fix cassette matching for VCR. Currently nearly all cassettes are matched/found based on the full request. Yet, many aspects of the request like header (containing the ohsome-py version) do not matter for the test itself. E.g. if the functionality of an endpoint is tested and that test is independent of the header, the cassette matching should only be done on the endpoint, not the header (https://cran.r-project.org/web/packages/vcr/vignettes/request_matching.html).
@SlowMo24 SlowMo24 added good first issue Good for newcomers testing Something needs testing labels Dec 6, 2023
SlowMo24 added a commit that referenced this issue Feb 16, 2024
@SlowMo24
feat(conftest): patch metadata return value
7cb9181 
this will prevent cassettes to be invalidated due to the metadata end_timestamp changing

Addresses #139
SlowMo24 added a commit that referenced this issue Feb 19, 2024
@SlowMo24
feat(conftest): patch metadata return value
34b7478 
this will prevent cassettes to be invalidated due to the metadata end_timestamp changing

Addresses #139
SlowMo24 added a commit that referenced this issue Jun 27, 2024
@SlowMo24
test(client): remove format bpolys test from client tests
db64b56 
addressing #139
SlowMo24 added a commit that referenced this issue Jul 4, 2024
@SlowMo24 @matthiasschaub
fix(helper): GeoSeries not working as bpolys input (#158)
addb892 
simplify bpoly formatting and tests

Addresses #139 
Closes #155 

Co-authored-by: Matthias (~talfus-laddus) <[email protected]>
@SlowMo24
Copy link
Collaborator Author

SlowMo24 commented Sep 3, 2024

  • check all tests for consistency, duplications and coherence
  • make sure all possible exceptions are also tested (white box testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers testing Something needs testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SlowMo24