Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyrRetro changes definition in TPL #15

Open
wStockhausen opened this issue Jan 8, 2024 · 0 comments
Open

nyrRetro changes definition in TPL #15

wStockhausen opened this issue Jan 8, 2024 · 0 comments

Comments

@wStockhausen
Copy link
Collaborator

In the TPL, nyrRetro is read in from gmacs.dat as the # of years to drop for the retrospective analysis (0 for no retro analysis). A couple of lines later, a new variable nyrRetroNo is set equal to nyrRetro. nyrRetro is then set equal to nyr-nyrRetro (i.e., it is now the last year of the retrospective analysis). This redefinition of nyrRetro is confusing and could easily be missed when looking at the code.

Solution: Make nyrRetroNo an init_int and read it in from gmacs.dat as nyrRetro currently is. Define nyrRetro as a regular int where nyrRetroNo is currently defined and set nyrRetro = nyr-nyrRetroNo. Same result as before, but no redefinition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant