Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mao findings #244

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Mao findings #244

wants to merge 10 commits into from

Conversation

natashapl
Copy link
Contributor

@natashapl natashapl commented Jan 8, 2025 •
edited
Loading

This pull request includes the following update:

PR Preview

maomeara63 and others added 5 commits November 26, 2024 12:37
@maomeara63 @jonadecker
Research findings
e67dd73 
Added research findings (without images or video). Also added new "research findings" tag to the News landing page and tags.md.
@jonadecker
tick updates
9a1d799
@natashapl
Updated page and styles. Added a bar chart.
0043322
@natashapl
Fixed the pull quotes on all pages
e3f304e 
Removed the asides since they were causing errors as a result of being within the main content landmark.
@natashapl
Removed an unneeded comment
2be093b
@natashapl natashapl linked an issue Jan 9, 2025 that may be closed by this pull request
Publish research findings #225
Open
@maomeara63
Copy link
Contributor

@natashapl

  • I only see one of the two videos, and the video that is there doesn't play. (I expect some controls to make it play?)
  • The chart at bottom isn't rendering correctly.

@jonadecker
Copy link
Contributor

Can we revisit the line-height on H2s @natashapl ? I don't think we often have H2s long enough to wrap but we do in this article and they're kind of giving a little awkward haircut vibe.
Screenshot 2025-01-09 at 10 22 07 AM

@natashapl natashapl marked this pull request as ready for review January 9, 2025 18:37
@natashapl natashapl marked this pull request as draft January 9, 2025 18:40
@jonadecker
Copy link
Contributor

This is probably what @maomeara63 was referring to:

Screenshot 2025-01-09 at 2 17 04 PM

@natashapl natashapl marked this pull request as ready for review January 11, 2025 05:44
@natashapl natashapl requested review from jonadecker, jonathanbobel and maomeara63 and removed request for jonadecker January 13, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanbobel jonathanbobel Awaiting requested review from jonathanbobel

@jonadecker jonadecker Awaiting requested review from jonadecker

@maomeara63 maomeara63 Awaiting requested review from maomeara63

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish research findings
3 participants
@natashapl @maomeara63 @jonadecker