Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: is_direct and passthrough handling #3236

Open
2 of 5 tasks
jadudm opened this issue Jan 19, 2024 · 2 comments
Open
2 of 5 tasks

Bug: is_direct and passthrough handling #3236

jadudm opened this issue Jan 19, 2024 · 2 comments
Labels

Comments

@jadudm
Copy link
Contributor

jadudm commented Jan 19, 2024

Working in: https://github.com/GSA-TTS/FAC/tree/jadudm/fix-passthrough-checks

Story

In Federal Awards, when is_direct is N, then both columns O and P are required. We were only checking O.

Tasks

Preview Give feedback
@jadudm jadudm added this to FAC Jan 19, 2024
@jadudm jadudm converted this from a draft issue Jan 19, 2024
@jadudm jadudm added the eng label Jan 19, 2024
@jadudm
Copy link
Contributor Author

jadudm commented Jan 20, 2024

See

#3240

before we go further on this ticket.

@jadudm jadudm moved this from Available to Triage in FAC Jan 20, 2024
@danswick danswick moved this from Triage to In Progress in FAC Feb 7, 2024
@danswick danswick moved this from In Progress to Blocked in FAC Feb 7, 2024
@danswick
Copy link
Contributor

danswick commented Oct 23, 2024

Next: discuss how we might start tracking these curation-related issues in one place.

More specifically: new validations where existing reports might fail to meet the threshold. If they had to be re-validated later, we can't just update a known value without interpreting the underlying audit or changing the submitter's intended meaning.

@danswick danswick moved this from Blocked to Backlog in FAC Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants