Update to new cloudfoundry provider

[rahearn]

Story

As a devops engineer,
I would like to use a better supported terraform provider for cloudfoundry,
So that I can be confident that everything works properly and will continue to work as api v2 goes away

Solution

Tasks

Preview Give feedback

1. Utilize https://registry.terraform.io/providers/cloudfoundry/cloudfoundry/latest/docs provider
2. Determine if this is a breaking change and rev the semver appropriately
3. Add UPGRADING.md file with information on mix-and-match new and old module versions & how to upgrade an existing module
4. Add a v1 branch to enable future bug fixes on that line.

Acceptance Criteria

• READMEs have been updated for appropriate version numbers
• space ssh and ASG things work properly

[rahearn]

more context/discussion: https://gsa-tts.slack.com/archives/C02U4Q9M5UH/p1729197775560979

[rahearn]

"breaking change" should be defined around both the parameters required for use of the modules as well as whether a resource created before the change can be cleanly managed by the provider after the change.

[mogul]

"breaking change" should be defined around both the parameters required for use of the modules as well as whether a resource created before the change can be cleanly managed by the provider after the change.

There's a lot of changes, and existing resources will have to be "orphaned" by removing them from the state, then re-importing them before the apply where the resource is updated to reference the new provider. The migration guide shows doing this with explicit terraform import CLI calls but I am pretty sure it could also be done with import blocks (which is probably better since the import and the reference to the new provider happen during the same apply).

[rahearn]

currently no ability to set a space security group to an existing security group cloudfoundry/terraform-provider-cloudfoundry#81

[rahearn]

Docs on passing providers explicitly to a module: https://developer.hashicorp.com/terraform/language/modules/develop/providers#passing-providers-explicitly

will be needed since v1 and v2 both use the cloudfoundry provider name