Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenger Manager's Dashboard (Phoenix) #1388

Closed
40 of 50 tasks
r-bartlett-gsa opened this issue Jul 24, 2024 · 16 comments
Closed
40 of 50 tasks

Challenger Manager's Dashboard (Phoenix) #1388

r-bartlett-gsa opened this issue Jul 24, 2024 · 16 comments
Assignees

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Jul 24, 2024

Note: This work needs to be deployed to challenge portal eval dev environment (challenge_gov repo > eval main branch)

User Story

As an user with a challenge manager role, in order to know the full scope of site features available for my role, I would like a dashboard-like page that lists role-specific features.

Acceptance Criteria:

Development tasks:

  • Task 1
  • Task 2

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
    - [ ] Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
    - [ ] Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
    - [ ] Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Usability testing: mobile and desktop (Tracy or Marni)
  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Jul 24, 2024

Image

Image

@r-bartlett-gsa
Copy link
Member Author

@stepchud Since this work was not started yet, should we move it to O&M team?

@jairoanaya
Copy link
Contributor

@r-bartlett-gsa please address the following design validation in order to continue: https://docs.google.com/document/d/1oQvEK4wbFyvwNHswglthWheYlk2fdRrJryaudtk6068/edit?usp=drive_link

@r-bartlett-gsa
Copy link
Member Author

@jairoanaya To answer your questions:

  • Please use the designs provided in the comment above
  • Yes, the side nav needs to be removed
  • The links to Submissions & Evaluations and Evaluation Forms are provided in the acceptance criteria

@jairoanaya
Copy link
Contributor

@r-bartlett-gsa to confirm:

The Submissions & Evaluation and Evaluation Forms links should be available to Admins also.
The internal header should be with H1 instead of H2 as shown in the images below to follow eval design pattern.
The util menu should be updated as well even if not listed in the acceptance criteria but shown in previous images.

Image
Image

@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Oct 30, 2024

@jairoanaya Please see my answers below:

The Submissions & Evaluation and Evaluation Forms links should be available to Admins also.

No, not at this time. While the design will change for Amin users, the dashboard options should not.

The internal header should be with H1 instead of H2 as shown in the images below to follow eval design pattern.

Yes, the header should be H1, and it should say "Dashboard".

The util menu should be updated as well even if not listed in the acceptance criteria but shown in previous images.

Yes, per our convo in #1364, the utility menu should reflect the dashboard options: #1364 (comment)

@jairoanaya
Copy link
Contributor

Evidence of deployment:
WAVE Rerport

Image
Image

Feature implemented:
Desktop

Challenge manager
Image

Non challenge manager
Image

Responsive
Image
Image

Notice util nav is updated.
Feedback discussed on this card has been implemented.

Pending PR Acceptance and staging validation to close card.

@jairoanaya
Copy link
Contributor

Work done:

@r-bartlett-gsa
Copy link
Member Author

@jairoanaya Below is my feedback:

  • For challenge manager role:
    • Remove dashboard page subtitle text "Engage with the features below to manage your workflows"
    • Change "Challenge management" to "Challenges", and remove "Create a new challenge"
    • Change Challenges card subtitle to "Create and manage your challenges."
    • Change "Help" to "Resources" and the subtitle to "Learn how to make the most of Challenge.gov and find support."
    • Add "Resources" to utility nav
    • Design screenshots for reference: Challenger Manager's Dashboard (Phoenix) #1388 (comment)
  • For all user roles:
    • Mobile utility nav: add line break between icons and titles
    • Now that side nav is removed, either reduce the page width (as on rails app) or add side margins
      Image

@jairoanaya
Copy link
Contributor

@r-bartlett-gsa I acknowledge the feedback. I expect to submit this feedback for PR on Monday 11/4 the latest.

@jairoanaya
Copy link
Contributor

Feedback submitted for PR. Expecting PR acceptance.

@jairoanaya
Copy link
Contributor

I confirm the latest updates is deployed on https://challenge-portal-eval-dev.app.cloud.gov/ and working as expected
You can see the PR here #1463

@r-bartlett-gsa
Copy link
Member Author

Thank you @jairoanaya! Looks great.

@mhotch24
Copy link
Contributor

mhotch24 commented Nov 6, 2024

@r-bartlett-gsa

Usability Findings:

  • Upper case 'Center' in 'Message center' card
  • Upper case 'Toolkit' in "Agency toolkit' card.

Feature A11y finding:

  • Cards: Screenreader is blending card title right into supportive text. Try code semantically and put them in wrapping block level tags. Possibly wrap each line in a p or div tag, and then the screen reader will separate them properly.

General A11y finding:

  • Skip to Main Content is not fully setup acrossRails and Eval-dev due to body content area not having appropriate ID: id="main-content".
  • 'Find a Challenge' voices 'Active Challenges'. It needs to say 'Find a Challenge'.

@r-bartlett-gsa
Copy link
Member Author

@jairoanaya Please address the following accessibility issue:

Screenreader is blending card title right into supportive text. Try code semantically and put them in wrapping block level tags. Possibly wrap each line in a p or div tag, and then the screen reader will separate them properly.

@jairoanaya
Copy link
Contributor

@r-bartlett-gsa @mhotch24 the following feedback has been implemented and deployed to https://challenge-portal-eval-dev.app.cloud.gov/

  • Upper case 'Center' in 'Message center' card
  • Upper case 'Toolkit' in "Agency toolkit' card.
  • Screenreader is blending has been resolved.

Important: Voice over have been resolved on #1362 , id="main-content" I believe is not necessary, current behavior is consistent with eval. Please double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants