From da2845314883af67d635813f2f20cf22f3a3f78d Mon Sep 17 00:00:00 2001
From: Emma Whamond <emma@smartlogic.io>
Date: Wed, 15 Jan 2025 18:13:50 -0600
Subject: [PATCH 1/2] Fix screenreader a11y error on challenge manager and
 evaluator stats

---
 app/views/phases/_submissions_stats.html.erb | 6 +++---
 app/views/shared/_assignment_stats.html.erb  | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/views/phases/_submissions_stats.html.erb b/app/views/phases/_submissions_stats.html.erb
index 72260580..9730fc05 100644
--- a/app/views/phases/_submissions_stats.html.erb
+++ b/app/views/phases/_submissions_stats.html.erb
@@ -25,15 +25,15 @@
 
         <div class="display-flex flex-row tablet:margin-left-auto">
             <div class="text-center margin-right-5">
-            <span class="font-sans-xl text-green text-bold"><%= @submissions_by_status[:completed] || 0 %></span><br>
+            <span class="font-sans-xl text-green text-bold display-block"><%= @submissions_by_status[:completed] || 0 %></span>
             <span class="font-sans-lg text-green text-bold">Completed</span>
             </div>
             <div class="text-center margin-right-5">
-            <span class="font-sans-xl text-accent-warm-dark  text-bold"><%= @submissions_by_status[:in_progress] || 0 %></span><br>
+            <span class="font-sans-xl text-accent-warm-dark text-bold display-block"><%= @submissions_by_status[:in_progress] || 0 %></span>
             <span class="font-sans-lg text-accent-warm-dark text-bold">In Progress</span>
             </div>
             <div class="text-center margin-right-2">
-            <span class="font-sans-xl text-secondary-dark text-bold"><%= @submissions_by_status[:not_started] || 0 %></span><br>
+            <span class="font-sans-xl text-secondary-dark text-bold display-block"><%= @submissions_by_status[:not_started] || 0 %></span>
             <span class="font-sans-lg text-secondary-dark text-bold">Not Started</span>
             </div>
         </div>
diff --git a/app/views/shared/_assignment_stats.html.erb b/app/views/shared/_assignment_stats.html.erb
index 09822cc1..be08f685 100644
--- a/app/views/shared/_assignment_stats.html.erb
+++ b/app/views/shared/_assignment_stats.html.erb
@@ -25,15 +25,15 @@
 
       <div class="display-flex flex-row tablet:margin-left-auto">
         <div class="text-center margin-right-1 margin-left-neg-1 tablet:margin-right-5">
-          <span class="font-sans-xl text-success-dark text-bold"><%= @submissions_count["completed"] || 0 %></span><br>
+          <span class="font-sans-xl text-success-dark text-bold display-block"><%= @submissions_count["completed"] || 0 %></span>
           <span class="font-sans-lg text-success-dark text-bold">Completed</span>
         </div>
         <div class="text-center margin-right-1 tablet:margin-right-4">
-          <span class="font-sans-xl text-accent-warm-dark text-bold"><%= @submissions_count["in_progress"] || 0 %></span><br>
+          <span class="font-sans-xl text-accent-warm-dark text-bold display-block"><%= @submissions_count["in_progress"] || 0 %></span>
           <span class="font-sans-lg text-accent-warm-dark text-bold">In Progress</span>
         </div>
         <div class="text-center margin-right-1 tablet:margin-right-2">
-          <span class="font-sans-xl text-error-dark text-bold"><%= @submissions_count["not_started"] || 0 %></span><br>
+          <span class="font-sans-xl text-error-dark text-bold display-block"><%= @submissions_count["not_started"] || 0 %></span>
           <span class="font-sans-lg text-error-dark text-bold">Not Started</span>
         </div>
       </div>

From a616868f63cd60935da8b2ea1752a3022aa9997a Mon Sep 17 00:00:00 2001
From: Emma Whamond <emma@smartlogic.io>
Date: Wed, 15 Jan 2025 18:25:01 -0600
Subject: [PATCH 2/2] 88 | Update test to include screenreader a11y fix

---
 spec/requests/evaluations_spec.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/spec/requests/evaluations_spec.rb b/spec/requests/evaluations_spec.rb
index e2a351b9..f6105864 100644
--- a/spec/requests/evaluations_spec.rb
+++ b/spec/requests/evaluations_spec.rb
@@ -224,9 +224,9 @@
           expect(response.body).to include("In Progress")
           expect(response.body).to include("Not Started")
 
-          expect(response.body).to include('<span class="font-sans-xl text-success-dark text-bold">1</span>')
-          expect(response.body).to include('<span class="font-sans-xl text-accent-warm-dark text-bold">1</span>')
-          expect(response.body).to include('<span class="font-sans-xl text-error-dark text-bold">1</span>')
+          expect(response.body).to include('<span class="font-sans-xl text-success-dark text-bold display-block">1</span>')
+          expect(response.body).to include('<span class="font-sans-xl text-accent-warm-dark text-bold display-block">1</span>')
+          expect(response.body).to include('<span class="font-sans-xl text-error-dark text-bold display-block">1</span>')
         end
       end