[287] Add User Status 'Role Change Needed' #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
stepchud
reviewed
Jan 4, 2025
app/models/user.rb
Outdated
Comment on lines
98
to
99
| USER_STATUSES = %w[pending active role_change_needed].freeze | ||
| validates :status, inclusion: { in: USER_STATUSES } |
There was a problem hiding this comment.
Some different, valid User statuses exist on the Phoenix app and we will have to support the same statuses on both apps. We will have to keep these in sync on both apps. Might also want to disambiguate role_change_needed from which role is needed, i.e. evaluator_role_requested in case we want others like challenge_manager_role_requested.
There was a problem hiding this comment.
Okay I'll go ahead and do that - thanks!
There was a problem hiding this comment.
@emmabjj Can you submit a PR on the Challenge_gov Phoenix repo against the eval-main branch that adds the new user status there too?
There was a problem hiding this comment.
@stepchud Sure! Here's that PR - GSA/Challenge_gov#1502
11 tasks
stepchud
reviewed
Jan 8, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: #287
Added an additional user status ('evaluator_role_requested') that is associated with existing users that need their role changed. That user's role needs to be changed to 'evaluator' by an admin, then their status becomes 'Available' for assignment to submissions.