[345] Evaluation Status #363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
stepchud
requested changes
Jan 17, 2025
| <td data-label=""> | ||
| <div class="display-flex flex-no-wrap grid-row"> | ||
| <% assignment = evaluator.evaluator_submission_assignments.where(submission_id: @submission.id).first %> | ||
| <% if assignment&.evaluation&.completed_at %> | ||
| <%= link_to(evaluation_path(evaluation)) do %> |
There was a problem hiding this comment.
this line raises an exception missing evaluation object
| @@ -1,3 +1,7 @@ | |||
| <% if @submission.evaluator_submission_assignments.recused.exists? %> | |||
| <%= render 'shared/alert_error', alert_heading: t('alerts.recused_evaluator.heading'), alert_text: t('alerts.recused_evaluator_submission.text') %> | |||
There was a problem hiding this comment.
Can you add some margin-bottom to the recused alert so it has some space between the alert and the assigned evaluators accordion?
| </td> | ||
| <td data-label="Score" class="text-top"> | ||
| <span class="margin-x-1"><%= evaluator_score(assignment).formatted_score %></span> | ||
| </td> | ||
| <td data-label=""> | ||
| <div class="display-flex flex-no-wrap grid-row"> |
There was a problem hiding this comment.
when the hotdog has two buns and there is more than one action button, the Assigned Evaluators table scrolls horizontally and looks off. can you make it display the buttons in vertical orientation and see if you can eliminate the horizontal scroll (if possible)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds evaluation status display to the assigned evaluators section of the submission details page.
Also adds an alert if there is a recused evaluator assigned and an error icon next to that evaluator's name.
Finally, adds a link to the evaluation if that evaluation is complete.