Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov website header/banner #5

Closed
23 of 32 tasks
stepchud opened this issue Jun 21, 2024 · 1 comment · Fixed by #176
Closed
23 of 32 tasks

Gov website header/banner #5

stepchud opened this issue Jun 21, 2024 · 1 comment · Fixed by #176
Assignees
@stonefilipczak
Milestone
Sprint 10/08/24

Comments

@stepchud
Copy link
Contributor

stepchud commented Jun 21, 2024 •
edited by r-bartlett-gsa
Loading

As a developer on the challenge platform, I would like to have a common header that can be used throughout the product as needed for consistent UX.

The base layout should include the Banner and Identifier components from the design system, as recommended to display the information required by law on US Gov websites.

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
  • Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
  • Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Move card to testing column in the board

Testing (dev team)

  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
  • Feature toggles if appropriate
  • Deploy to staging

Staging

  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Usability testing: mobile and desktop (Tracy or Marni)
  • Cross browser testing (tool to be determined) (Tracy or Marni)
    • UI rendering is performant
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata and Michelle)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 07/02/24 milestone Jun 21, 2024
@r-bartlett-gsa r-bartlett-gsa changed the title Create a basic application layout Gov website header/banner Aug 8, 2024
@stonefilipczak stonefilipczak mentioned this issue Aug 19, 2024
Merged
stepchud added a commit that referenced this issue Sep 3, 2024
@stonefilipczak @stepchud
[#25,#5, #27] Header / Nav / Banner / Utility Menu (#124)
39dee1e 
* government banner
* header
* mobile nav

Co-authored-by: Stephen Chudleigh <[email protected]>

* shared specs for utility menu
* increase threshold for similar code

---------

Co-authored-by: Stephen Chudleigh <[email protected]>
Co-authored-by: Stephen Chudleigh <[email protected]>
cpreisinger added a commit that referenced this issue Sep 4, 2024
@cpreisinger
Merge branch 'dev' of github.com:GSA/Challenge_platform into 56/share…
7d6bfff 
…d-rails-phoenix-session

* 'dev' of github.com:GSA/Challenge_platform: (21 commits)
  [#25,#5, #27] Header / Nav / Banner / Utility Menu (#124)
  Adjust puma config
  Manifest and config tweak
  Config tweaks
  adjust asset precompile
  Configure default proxy if env set
  Adjust ports
  Memory tweaks
  env tweaks
  Memory tweak
  More memory
  Adjust sidecar boot
  Move proxy into its own manifest
  Add local proxy sidecar
  34 Use skip before action instead of except for timeout
  34 Readability fix for check_session_expiration
  34 Fix for timeout not redirecting properly
  34 Remove session timeout from .envrc
  34 Change session timeout env var to a constant
  34 Fix failing session timeout test
  ...
@mhotch24
Copy link

@stepchud is this card ready for testing? Nothing checked off. Thanks!

@stonefilipczak stonefilipczak linked a pull request Sep 25, 2024 that will close this issue
[25, 5] fix wave errors on header #176
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonefilipczak stonefilipczak

Labels
None yet
Projects
None yet
Milestone
Sprint 10/08/24
Development

Successfully merging a pull request may close this issue.

[25, 5] fix wave errors on header GSA/Challenge_platform
5 participants
@stepchud @stonefilipczak @r-bartlett-gsa @mhotch24 @TCKapGrp