Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Signed Commits for Datagov-bot #5037

Closed
3 tasks
btylerburton opened this issue Jan 13, 2025 · 2 comments
Closed
3 tasks

Enable Signed Commits for Datagov-bot #5037

btylerburton opened this issue Jan 13, 2025 · 2 comments
Assignees
Labels
compliance Relating to security compliance or documentation security Pull requests that address a security vulnerability

Comments

@btylerburton
Copy link
Contributor

User Story

In order to allow for the commits made by the datagov-bot to be verified, datagovteam wants to sign its commits.

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

  • GIVEN the datagov-bot wants to add commits to the project
    THEN I want to make sure those commmits are signed so as to pass the repository's new security rules that enforce commit signing

Background

Here's a few threads on enabling signed commits by github bots:

Security Considerations (required)

[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]

Sketch

  • enable signed commits on datagov-bot, or create a new bot that has signed commits and swap that in for the original datagov-bot
  • enable this new/updated bot in all datagov repos
@btylerburton btylerburton added compliance Relating to security compliance or documentation security Pull requests that address a security vulnerability labels Jan 13, 2025
@btylerburton
Copy link
Contributor Author

LLM does a good job summarizing the steps. Not sure if it's hallucinating the details though:

Screenshot 2025-01-13 at 17 16 34

@btylerburton btylerburton self-assigned this Jan 14, 2025
@btylerburton btylerburton moved this to 🏗 In Progress [8] in data.gov team board Jan 14, 2025
@btylerburton
Copy link
Contributor Author

added a signing key.
can confirm it works once datagov-bot adds some new commits.

@github-project-automation github-project-automation bot moved this from 🏗 In Progress [8] to ✔ Done in data.gov team board Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compliance Relating to security compliance or documentation security Pull requests that address a security vulnerability
Projects
Status: ✔ Done
Development

No branches or pull requests

1 participant