Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved profile catalogs generate validation errors #1102

Open
1 of 12 tasks
Rene2mt opened this issue Jan 15, 2025 · 0 comments · Fixed by #1103
Open
1 of 12 tasks

Resolved profile catalogs generate validation errors #1102

Rene2mt opened this issue Jan 15, 2025 · 0 comments · Fixed by #1103
Assignees
Labels
bug Something isn't working

Comments

@Rene2mt
Copy link
Member

Rene2mt commented Jan 15, 2025

This relates to ...

  • the FedRAMP OSCAL Registry
  • the FedRAMP OSCAL baselines
  • the Guide to OSCAL-based FedRAMP Content
  • the Guide to OSCAL-based FedRAMP System Security Plans (SSP)
  • the Guide to OSCAL-based FedRAMP Security Assessment Plans (SAP)
  • the Guide to OSCAL-based FedRAMP Security Assessment Results (SAR)
  • the Guide to OSCAL-based FedRAMP Plan of Action and Milestones (POA&M)
  • the FedRAMP SSP OSCAL Template (JSON or XML Format)
  • the FedRAMP SAP OSCAL Template (JSON or XML Format)
  • the FedRAMP SAR OSCAL Template (JSON or XML Format)
  • the FedRAMP POA&M OSCAL Template (JSON or XML Format)
  • the FedRAMP OSCAL Validations

What happened?

It turns out that when generating resolved profile catalogs (e.g., using the OSCAL CLI) from the FedRAMP profiles, the resulting resolved profile catalogs fail validation because:

  1. there are a few instances where the profiles add a part with a duplicate ID
  2. there are numerous instances where the profiles add a part with name="guidance", however, because the profile alterations do not specify the namespace, the resulting resolved profile catalogs fail validation since 'guidance' doesn't match one of 'assessment-objective, item, or objective' for core OSCAL catalog parts.

NOTE - The same issues are present in the HIGH, MODERATE, LOW, and LI-SAAS baselines

Relevant log output

How do we replicate this issue?

  1. Take one of the published FedRAMP profiles from the master or develop branch
  2. Using OSCAL CLI (v2.4.0), use the following command to resolve the profile:
oscal-cli resolve-profile --to=XML https://raw.githubusercontent.com/GSA/fedramp-automation/refs/heads/master/src/content/rev5/baselines/xml/FedRAMP_rev5_HIGH-baseline_profile.xml FedRAMP_rev5_High_RPC.xml
  1. Using OSCAL CLI (v2.4.0), use the following command to validate the profile:
oscal-cli validate FedRAMP_rev5_High_RPC.xml

Where, exactly?

Fixes only need to be made to the XML profiles, and will cascade to the all formats (XML, JSON, and YAML) during CI profile resolution and conversion.

Other relevant details

No response

@Rene2mt Rene2mt added the bug Something isn't working label Jan 15, 2025
@Rene2mt Rene2mt self-assigned this Jan 15, 2025
@Rene2mt Rene2mt moved this from 🆕 New to 🏗 In progress in FedRAMP Automation Jan 15, 2025
@Rene2mt Rene2mt mentioned this issue Jan 15, 2025
7 tasks
@Rene2mt Rene2mt moved this from 🏗 In progress to 👀 In review in FedRAMP Automation Jan 15, 2025
@Rene2mt Rene2mt linked a pull request Jan 15, 2025 that will close this issue
7 tasks
@Rene2mt Rene2mt moved this from 👀 In review to 🚢 Ready to Ship in FedRAMP Automation Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging a pull request may close this issue.

1 participant