Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Page: Recent job reports not displaying (for some one-off sends) #1859

Closed
em-herrick opened this issue Aug 16, 2024 · 5 comments · Fixed by #1864
Closed

Activity Page: Recent job reports not displaying (for some one-off sends) #1859

em-herrick opened this issue Aug 16, 2024 · 5 comments · Fixed by #1864
Assignees

Comments

@em-herrick
Copy link
Contributor

em-herrick commented Aug 16, 2024

Some jobs on Washinton's service even when sent less than 7-days ago are not displaying as downloadable on the All Activity table. (Screen shot shows a message sent yesterday, 8/15, as n/a).

Image

This only seems to be the case on Washington's service. @em-herrick can provide an invite to their service as needed to investigate.

@em-herrick em-herrick converted this from a draft issue Aug 16, 2024
@em-herrick em-herrick added the bug label Aug 16, 2024
@heyitsmebev heyitsmebev self-assigned this Aug 16, 2024
@heyitsmebev heyitsmebev moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Aug 16, 2024
@heyitsmebev heyitsmebev linked a pull request Aug 16, 2024 that will close this issue
@heyitsmebev heyitsmebev removed a link to a pull request Aug 16, 2024
@heyitsmebev
Copy link
Contributor

heyitsmebev commented Aug 19, 2024

I updated the UI conditionals to ensure that "N/A" shows up after 7 days.
#1864

However, this ticket requires the attention of a backend engineer to verify that the job exists and that the created_at timestamp is correctly recorded.

The issue at hand involves the display of the download button, which is dependent on the availability of the job's data. The get_time_left function calculates the time left based on the created_at timestamp. If the data retention period has passed, this function returns "Data no longer available," causing the table to display "N/A" instead of the download link, which would otherwise call view_job_csv.

We need to ensure that the created_at timestamp for the job is accurate and consistent.

In this example, two jobs appears to be processed around the same time, but check to see if created_at is accurate.
image

A while back, there was this ticket created related to created_at not being accurate. It could be related: GSA/notifications-api#1199

@heyitsmebev heyitsmebev removed their assignment Aug 19, 2024
@heyitsmebev heyitsmebev moved this from 🏗 In progress (WIP: ≤ 3 per person) to ⬇ Up-Next in Notify.gov product board Aug 19, 2024
@terrazoon terrazoon self-assigned this Aug 19, 2024
@terrazoon terrazoon moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Aug 19, 2024
@heyitsmebev heyitsmebev linked a pull request Aug 20, 2024 that will close this issue
@heyitsmebev
Copy link
Contributor

GSA/notifications-api#1284 (possible fix to created_at issue)

@heyitsmebev
Copy link
Contributor

@em-herrick

It looks like the issue may be resolved with @terrazoon's PR, which ensures the created_at timestamp is accurate. However, if this PR did indeed fix the issue, we still cannot change the timestamps for past jobs in the database. As a result, the download CSV file that were missing on the Activity page may exceed the 7-day limit, making that data unavailable to users.

@em-herrick
Copy link
Contributor Author

@heyitsmebev thanks for the flag. I didn't check the time-based reports, and wonder if these jobs show up in the there, i assume they are because we haven't heard otherwise from partners.

To clarify, this issue wasn't surfaced from a partner directly, I found it as I was clicking through the WA service. So i think that it will be okay if we've fixed this for future jobs :)

@heyitsmebev heyitsmebev moved this from 🏗 In progress (WIP: ≤ 3 per person) to ✅ Done in Notify.gov product board Aug 29, 2024
@ccostino
Copy link
Contributor

This has now been taken care of!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants