Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create wireframe for Comparison Tool #168

Open
mgifford opened this issue Sep 1, 2021 · 6 comments
Open

Create wireframe for Comparison Tool #168

mgifford opened this issue Sep 1, 2021 · 6 comments
Labels
comparison tool Issues tied to the comparison tool specifically

Comments

@mgifford
Copy link
Collaborator

mgifford commented Sep 1, 2021 •
edited
Loading

When comparing different ACR, what do we want to highlight? How do we want that information to be presented? Will it be the YAML file, the Markdown or HTML that would be easiest to review?

I think initially we were looking for something like the output that https://www.diffchecker.com/diff provides.

Screen Shot of diff of 2 OPAT files

Also related - #69
@dmundra
Copy link
Collaborator

dmundra commented Sep 1, 2021

Ideally, we are diffing the YAML file but also contextually we are providing diffing the output of markdown or HTML (by user choice). I like how GitHub does 'rich diff' of the text so I would try that if possible. Example screenshot:

Screenshot of the readme changes

@bruce-usab
Copy link

bruce-usab commented Sep 1, 2021 •
edited
Loading

I am taking the liberty to share my unsolicited perspective as someone who is very enthusiastic about this work, but concerned that I lack the time and expertise to actively contribute.

I recommend that you explore if it is not too much work to allow both views for comparison.

I don't think the average 508 program manager can be expected to make much sense of a GitHub style PR diff view.

That said, the early adopters will be GitHub users, so that sort of data view is fine for that audience. Also, anyone manually troubleshooting the importing of MS ACRs (from VPAT) will appreciate the availability of a traditional diff presentation.

So I think any diff presentation first but knowing that an option for a GitHub style document-like 'rich diff' needs to be part of the beta launch.

@dmundra
Copy link
Collaborator

dmundra commented Sep 1, 2021

Thanks for the feedback @bruce-usab. Agreed with your points. Hopefully, we can bug you for feedback on the tool once we have it ready for that review.

@mgifford
Copy link
Collaborator Author

mgifford commented Sep 1, 2021 •
edited
Loading

What if the comparison were just in a single window like this:

<!DOCTYPE html>
<html>
<frameset cols="*,*,*">
    <frame title="Plone" src="Plone-5.html">
    <frame title="Drupal" src="drupal-9.html">
    <frame title="Moodle" src="Moodle-3.html">
</frameset>
</html>

We could add some JavaScript to start to highlight things where there are differences between them.

Possibly highlight

  • the oldest OPAT
  • places where information is missing
  • using red, yellow, green (along with symbols) to indicate supports, partially-supports and does-not-support

We could actually aggregate some findings between OPATs that are involved. Help prepare material that might be the basis for a "best meets" accessibility documentation.

Ideally you could lock the view so that as you scroll up/down one, the others jump along between the appropriate sections.

Screen Shot comparing HTML versions of OPATs

  • Note I edited the HTML in the screenshot to reflect problems that don't actually exist.

@mgifford mgifford added the comparison tool Issues tied to the comparison tool specifically label Sep 17, 2021
@mgifford
Copy link
Collaborator Author

mgifford commented Sep 20, 2021 •
edited
Loading

Have a very basic model of this up and running now on the draft website - [EDIT: URL Updated to use Githack]

@mgifford
Copy link
Collaborator Author

mgifford commented Dec 6, 2021 •
edited
Loading

Any comparison should focus on supporting procurement officers to have a better understanding of the context. Simply having more or less errors in an ACR is insufficient to determine if a product is more or less accessible for a given project. Comparisons can prompt officers to look for manual testing or ask the vendor to provide more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comparison tool Issues tied to the comparison tool specifically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgifford @dmundra @bruce-usab