Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory - links to internal comments/determinations #68

Open
grugnog opened this issue Jul 29, 2021 · 2 comments
Open

Directory - links to internal comments/determinations #68

grugnog opened this issue Jul 29, 2021 · 2 comments
Labels
user interface Any OpenACR UI

Comments

@grugnog
Copy link
Collaborator

grugnog commented Jul 29, 2021

Allows agency users to locate internal pages where they can capture interpretations on the OPAT and check if/how they can use software

@mgifford mgifford added the user interface Any OpenACR UI label Aug 20, 2021
@mgifford
Copy link
Collaborator

@dmundra how are we presently managing optional elements? Things like multiple addresses?

If a software vendor wanted to add internal documentation, comments or links which could be used for internal purposes only, I guess that we could provide for options like:

  • internal_data
  • internal_links
  • internal_comments

It would complicate any UI's though as we'd need to have a publish internal vs publish external option.

This is out of scope for this time.

@dmundra
Copy link
Collaborator

dmundra commented Aug 23, 2021

Sorry for the delay @mgifford.

how are we presently managing optional elements? Things like multiple addresses?

Optional elements are not required by the schema or custom validate code. Then for templating handlebars allows us to use if/else to check if optional elements exist and only show them if they do. E.g. https://github.com/GSA/open-product-accessibility-template/blob/main/templates/opat-markdown-0.1.0.handlebars#L26-L34

Internal fields can definitely be added if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user interface Any OpenACR UI
Projects
None yet
Development

No branches or pull requests

3 participants